Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to NXP PDM MICFIL Zephyr native driver on i.MX8MP #9824

Merged
merged 4 commits into from
Feb 12, 2025

Conversation

dbaluta
Copy link
Collaborator

@dbaluta dbaluta commented Feb 10, 2025

This is the last part of switching from SOF driver to Zephyr native drivers for NXP platforms. After this gets merged in we will do cleanup for SOF drivers and remove them.

This pulls in NXP PDM MICFIL drivers changes from Zephyr:

aaa119d757294 dts: xtensa: nxp_imx8m: Add PDM MICFIL node
715fbd1f81ced drivers: dai: Add initial support for NXP MICFIL PDM IP

Signed-off-by: Daniel Baluta <[email protected]>
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would just add a comment (to make it easier later on when we remove legacy)

@@ -73,6 +73,9 @@ int dai_config_dma_channel(struct dai_data *dd, struct comp_dev *dev, const void
case SOF_DAI_IMX_MICFIL:
channel = dai_get_handshake(dd->dai, dai->direction,
dd->stream_id);
#ifdef CONFIG_ZEPHYR_NATIVE_DRIVERS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to have an inline comment here stating why this is needed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure.

Support PDM MICFIL interface with Zephyr native driver interface.
SOF PDM MICFIL driver is no longer supported and it will be soon
removed.

Signed-off-by: Daniel Baluta <[email protected]>
With Zephyr native driver we use timer domain.

Signed-off-by: Daniel Baluta <[email protected]>
Enable PDM MICFIL dts node and config option.

Signed-off-by: Daniel Baluta <[email protected]>
@dbaluta
Copy link
Collaborator Author

dbaluta commented Feb 10, 2025

Changes since v2:

  • added a comment documenting the use of ifdef native drivers.

@dbaluta
Copy link
Collaborator Author

dbaluta commented Feb 11, 2025

@lgirdwood @lyakh care to look at intel tests failing? are they caused by the west.yml update?

@lgirdwood
Copy link
Member

@lgirdwood @lyakh care to look at intel tests failing? are they caused by the west.yml update?

Results look as expected. @lyakh pls review.

@dbaluta dbaluta merged commit 1270b22 into thesofproject:main Feb 12, 2025
44 of 48 checks passed
@kv2019i
Copy link
Collaborator

kv2019i commented Feb 12, 2025

Merge was done while I was still writing this, but I'll submit anyways. Most of the Intel fails seem unrelated to the PR, but not 100% sure about this:
https://sof-ci.01.org/sofpr/PR9824/build10612/devicetest/index.html?model=LNLM_RVP_NOCODEC&testcase=check-suspend-resume-with-capture-5

It's a DSP panic on LNL I don't recall seeing with SOF main. Not much in the logs. Could be good/bad luck hitting a rare bug or an issue triggered by the Zephyr baseline update (it's been a full month and ~2000 commits since last update).

We'll soon see whether this starts to pop up in other PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants