Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revocation TAP #182

Merged
merged 4 commits into from
Mar 19, 2024
Merged

Revocation TAP #182

merged 4 commits into from
Mar 19, 2024

Conversation

mnm678
Copy link
Contributor

@mnm678 mnm678 commented Jan 30, 2024

This TAP splits out revocation from TAP 8 to simplify both proposals as discussed in #37. This TAP relies on changes to TAP 8 proposed in #167.

@mnm678 mnm678 marked this pull request as draft January 30, 2024 18:24
@mnm678 mnm678 marked this pull request as ready for review February 2, 2024 15:58
revocation-tap.md Show resolved Hide resolved
Signed-off-by: Marina Moore <[email protected]>
joshuagl
joshuagl previously approved these changes Mar 19, 2024
Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor nits, but I really like making this a separate TAP. Thanks.

revocation-tap.md Outdated Show resolved Hide resolved
revocation-tap.md Outdated Show resolved Hide resolved
Signed-off-by: Marina Moore <[email protected]>
Copy link

@kipz kipz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mnm678 mnm678 merged commit e7d1a04 into theupdateframework:master Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants