Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TAP 8] Describe DoS attack and prevention #183

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

mnm678
Copy link
Contributor

@mnm678 mnm678 commented Feb 7, 2024

No description provided.

@kipz
Copy link

kipz commented Feb 26, 2024

@mnm678 it looks like you're thinking this is something that implementors can choose mitigate, but couldn't this be a formal part of the spec; that is, put the limit in the metadata and make it so the client MUST fail if the number of revocation files is greater than the limit?

@JustinCappos
Copy link
Member

I would tend to agree that at a minimum, the existence of a limit and discussion around this should be in the document.

Note that if there is a limit, what if some clients have a different limit than others? This will cause a divergence in views of the repo. So this almost certainly needs to be a per-repository setting based upon information in the root metadata.

@kipz
Copy link

kipz commented Feb 26, 2024

Makes sense.

I think this differs from the similar attack mentioned in #37 whereby any key holder can upload several different versions of the same metadata file. A revocation limit is something that could be defined ahead of time, whereas the number of metadata file versions really is unknown.

Signed-off-by: Marina Moore <[email protected]>
@mnm678
Copy link
Contributor Author

mnm678 commented Mar 4, 2024

I added some text about this. I think it can be addressed at the repository side by limiting uploads of rotate files after a certain point. This allows the repository to set the limit based on their available storage/hosting resources, and to share this limit with all clients.

tap8.md Outdated Show resolved Hide resolved
Signed-off-by: Marina Moore <[email protected]>
@mnm678 mnm678 merged commit 60e950f into theupdateframework:master Apr 9, 2024
@mnm678 mnm678 deleted the many-rotates branch April 9, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants