Fix and extend targets rollback test #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a test for simple targets rollback * Fix the test for targets rollback when metafile hashes are used This now leads to the latter test failing because of theupdateframework#128: This PR can be used to test the fix for theupdateframework#128. This PR should not be merged before that. Signed-off-by: Jussi Kukkonen <[email protected]>
jku
force-pushed
the
fix-and-extend-targets-rollback-test
branch
from
63a8b9c to
b376d2a
Compare
We can parametrize these tests so that they work both with and without hashes: * Replace two targets rollback tests with a parametrized test * Replace on snapshot rollback test with a parametrized test (the "with hashes" case was not tested before) Signed-off-by: Jussi Kukkonen <[email protected]>
|
closing for #154 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This now leads to the "with hashes" tests failing because of #128: I believe the tests are correct. This PR can be used to test the fix for #128.
This PR is ready for review but should not be merged before the fix for #128.