Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repo: Use delegation tree to decide which metadata to include in publishing #344

Merged
merged 1 commit into from
May 23, 2024
Merged

repo: Use delegation tree to decide which metadata to include in publishing #344

merged 1 commit into from
May 23, 2024

Conversation

jku
Copy link
Member

@jku jku commented May 22, 2024

Using snapshot contents is incorrect as snapshot is allowed to contain files that are no longer needed.

Fixes #342

@jku
Copy link
Member Author

jku commented May 22, 2024

self review:

  • we really should have validation for build_repository(): I resisted the urge to slap some validation code in between as I think it makes sense to make that consciously and use the same code in online-sign as well Validation for online-sign and build-repository #343
  • there is no test for this since tuf-on-ci does not currently have CLI support for removing delegations (issue only came up since sigstore root-signing has removed delegations) -- this is not a big thing to add but it's not been needed so far...

@jku
repo: Use delegation tree to decide which metadata to include
71623d3 
Using snapshot contents is incorrect as snapshot is allowed to contain
files that are no longer needed.

Fixes theupdateframework#342
@jku jku force-pushed the use-delegation-tree-in-build-repository branch 2 times, most recently from 9a11bb9 to 71623d3 Compare May 22, 2024 10:43
@jku jku marked this pull request as ready for review May 22, 2024 10:59
joshuagl
joshuagl approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jku jku merged commit 28e6a8d into theupdateframework:main May 23, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuagl joshuagl joshuagl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

investigate build-repository failure
2 participants
@jku @joshuagl