Handle empty email to case

thewca · Jul 24, 2023 · 3fe23bd · 3fe23bd
1 parent 12290dc
commit 3fe23bd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/main/java/org/worldcubeassociation/dbsanitycheck/service/impl/EmailServiceImpl.java b/src/main/java/org/worldcubeassociation/dbsanitycheck/service/impl/EmailServiceImpl.java
@@ -45,7 +45,7 @@ public class EmailServiceImpl implements EmailService {
     public void sendEmail(String emailTo, List<AnalysisBean> analysisResult,
                           List<SanityCheckWithErrorBean> queriesWithError)
             throws MessagingException {
-        if (sendMail) {
+        if (sendMail && emailTo.length() > 0) {
             log.info("Sending email with the analysis");
 
             MimeMessage message = emailSender.createMimeMessage();

diff --git a/...n/java/org/worldcubeassociation/dbsanitycheck/service/impl/WrtSanityCheckServiceImpl.java b/...n/java/org/worldcubeassociation/dbsanitycheck/service/impl/WrtSanityCheckServiceImpl.java
@@ -19,6 +19,7 @@
 import java.util.Iterator;
 import java.util.List;
 import java.util.Map;
+import java.util.Optional;
 import java.util.stream.Collectors;
 import javax.mail.MessagingException;
 
@@ -47,7 +48,7 @@ public void execute() throws MessagingException {
         log.info("Found {} queries", sanityChecks.size());
 
         Map<String, List<SanityCheck>> sanityChecksByEmail = sanityChecks.stream()
-                .collect(Collectors.groupingBy(s -> s.getCategory().getEmailTo()));
+                .collect(Collectors.groupingBy(s -> Optional.ofNullable(s.getCategory().getEmailTo()).orElse("")));
         log.info("Found {} emails", sanityChecksByEmail.size());
 
         for (Map.Entry<String, List<SanityCheck>> entry : sanityChecksByEmail.entrySet()) {