Skip to content

Commit

Permalink
ci: add explicit dependency on build job
Browse files Browse the repository at this point in the history
Prevent progression of the workflow if a build job is cancelled or skipped.

Resolves #2908

Signed-off-by: Reuben Miller <[email protected]>
  • Loading branch information
reubenmiller committed May 30, 2024
1 parent 0b10fa0 commit 613e8dd
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,7 @@ jobs:
github.event_name != 'pull_request_target' &&
(needs.test.result == 'success' || needs.test.result == 'skipped')
runs-on: ubuntu-20.04
needs: [test]
needs: [build, test]
strategy:
fail-fast: false
matrix:
Expand Down Expand Up @@ -302,7 +302,7 @@ jobs:
github.event_name != 'pull_request_target' &&
(needs.test.result == 'success' || needs.test.result == 'skipped')
runs-on: ubuntu-20.04
needs: [test]
needs: [build, test]
env:
BUILDX_NO_DEFAULT_ATTESTATIONS: 1
permissions:
Expand Down

0 comments on commit 613e8dd

Please sign in to comment.