fix trim test

crates/core/c8y_api/src/smartrest/message.rs

@@ -24,7 +24,9 @@ pub const MAX_PAYLOAD_LIMIT_IN_BYTES: usize = 16000;
 ///
 /// - https://cumulocity.com/docs/smartrest/smartrest-introduction/
 #[derive(Debug, Clone, PartialEq, Eq)]
-pub struct SmartrestPayload(String);
+// TODO: pub(crate) for now so it can be constructed manually in serializer::succeed_operation, need to figure out a
+// good API
+pub struct SmartrestPayload(pub(crate) String);
 
 impl SmartrestPayload {
     /// Creates a payload that consists of a single record.

crates/core/c8y_api/src/smartrest/smartrest_serializer.rs

@@ -156,13 +156,10 @@ pub fn succeed_operation(
         }
         let trimmed_reason = &reason[..max_result_limit];
 
-        let new_reason = format!("{trimmed_reason}{trim_indicator}");
-
-        SmartrestPayload::serialize((template_id, operation, new_reason))
-            .expect("shouldn't be too large and serialization should succeed")
+        format!("{prefix},\"{trimmed_reason}{trim_indicator}\"")
     };
 
-    Ok(result)
+    Ok(SmartrestPayload(result))
 }
 
 pub fn succeed_operation_with_name(
@@ -634,7 +631,7 @@ mod tests {
 
     /// Make sure that `reason` field is trimmed correctly, even in presence of double quote
     /// sequences.
-    #[test_case(MAX_PAYLOAD_LIMIT_IN_BYTES - 1, 0; "skips_final_quote_because_wont_fit")]
+    #[test_case(MAX_PAYLOAD_LIMIT_IN_BYTES - 1, 2; "skips_final_quote_because_wont_fit")]
     #[test_case(MAX_PAYLOAD_LIMIT_IN_BYTES - 2, 4; "preserves_final_quote_because_fits")]
     fn succeed_operation_trims_reason_field_3171(message_len: usize, expected_num_quotes: usize) {
         let prefix_len = "503,c8y_Command,".len();