Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove debug print statement #2786

Conversation

reubenmiller
Copy link
Contributor

Proposed changes

Remove a debug print statement introduced by #2716.

The unexpected debug print statements were noticed when running tedge connect|reconnect c8y:

$ sudo tedge reconnect c8y
# ...
Restarting mosquitto service.

[crates/core/tedge/src/cli/connect/command.rs:546] path.as_ref() = "/etc/tedge/device-certs/tedge-certificate.pem"
[crates/core/tedge/src/cli/connect/command.rs:546] path.as_ref() = "/etc/tedge/device-certs/tedge-private-key.pem"
Awaiting mosquitto to start. This may take up to 5 seconds.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue


Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 77.1%. Comparing base (44abd79) to head (19773d6).
Report is 37 commits behind head on main.

Additional details and impacted files
Files Coverage Δ
crates/core/tedge/src/cli/connect/command.rs 0.0% <0.0%> (ø)

... and 48 files with indirect coverage changes

Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
422 0 3 422 100 0s

Copy link
Contributor

@didier-wenzek didier-wenzek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@reubenmiller reubenmiller added this pull request to the merge queue Mar 17, 2024
Merged via the queue into thin-edge:main with commit 8195681 Mar 17, 2024
32 checks passed
@reubenmiller reubenmiller deleted the fix-remove-mosquitto-restart-print-debug branch July 18, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants