Rename mqtt_channel::Message -> MqttMessage #2817
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Make the distinction between
tedge_actors::Message
andmqtt_channel::MqttMessage
explicit.It was not really confusing as one is a
struct
and the other atrait
, however the distinction helps to stress that actors such as the c8y converter are currently driven by MQTT messages. What I really want to change is the latter point: the c8y converter should not manipulate raw MQTT messages but parsed c8y + tedge messages. This PR is a first step in that direction.Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments