Deprecate tedge topic parsing method #2818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Didier Wenzek <[email protected]>
didier-wenzek
requested review from
albinsuresh,
jarhodes314 and
rina23q
as code owners
didier-wenzek
temporarily deployed
to
Test Pull Request
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
|
Robot Results
|
Bravo555
reviewed
Apr 9, 2024
Comment on lines
+100
to
+110
| let child_id = match topic.split('/').collect::<Vec<&str>>()[..] { | ||
| // This plugin is still listening to the deprecated `tedge` command topic | ||
| ["tedge", child_id, "commands", "res", "firmware_update"] if !child_id.is_empty() => { | ||
| child_id.to_string() | ||
| } | ||
| _ => { | ||
| return Err(FirmwareManagementError::InvalidTopicFromChildOperation { | ||
| topic: topic.into(), | ||
| }) | ||
| } | ||
| }; |
There was a problem hiding this comment.
note: I think this not only removes the deprecated function, but also fixes the wrong behaviour
Previously get_child_id_from_child_topic just extracted child id, but the topic itself wasn't checked, so it could be anything.
There was a problem hiding this comment.
Indeed, this also fixes the behavior and I failed to missed that trying at first to use one of the tedge_api::MqttSchema method!
Bravo555
approved these changes
Apr 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
didier-wenzek
deleted the
refactor/deprecate-get_child_id_from_child_topic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Deprecate
get_child_id_from_child_topic, a method parsing the now deprecatedtedgecommand topic.Types of changes
Paste Link to the issue
Checklist
cargo fmtas mentioned in CODING_GUIDELINEScargo clippyas mentioned in CODING_GUIDELINESFurther comments