Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct topic and payload in registration in reference c8y-mapper guide #2827

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Correct topic and payload in registration in reference c8y-mapper guide #2827

merged 1 commit into from
Apr 18, 2024

Conversation

rina23q
Copy link
Member

@rina23q rina23q commented Apr 18, 2024

Proposed changes

Correct topic and payload described in References > Cumulocity Mapper > Registration

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
  • Documentation Update (if none of the other choices apply)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

#2807

Checklist

  • I have read the CONTRIBUTING doc
  • I have signed the CLA (in all commits with git commit -s)
  • I ran cargo fmt as mentioned in CODING_GUIDELINES
  • I used cargo clippy as mentioned in CODING_GUIDELINES
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

@rina23q rina23q temporarily deployed to Test Pull Request April 18, 2024 09:43 — with GitHub Actions Inactive
reubenmiller
reubenmiller approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@reubenmiller reubenmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@github-actions GitHub Actions
Copy link
Contributor

Robot Results

✅ Passed ❌ Failed ⏭️ Skipped Total Pass % ⏱️ Duration
428 0 3 428 100 0s

@rina23q rina23q added this pull request to the merge queue Apr 18, 2024
Merged via the queue into thin-edge:main with commit b3594ef Apr 18, 2024
30 checks passed
@rina23q rina23q deleted the docs/2807/correct-reference-c8y-mapper-registration-description branch July 18, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reubenmiller reubenmiller reubenmiller approved these changes

@didier-wenzek didier-wenzek Awaiting requested review from didier-wenzek didier-wenzek is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rina23q @reubenmiller