fix: apply delay to mqtt connect errors by default

[Bravo555]

Proposed changes

Instead of retrying MQTT connection immediately for some errors, apply delay before retrying connection by default for all errors.

One could argue that for errors where we know we're going to receive it again, e.g. misconfiguring certificates, we should exit instead of retrying, but because rumqttc doesn't organize its errors very well, it would be hard to ensure that every variant is covered, whereas this is simple and works.

Types of changes

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Improvement (general improvements like code refactoring that doesn't explicitly fix a bug or add any new functionality)
• Documentation Update (if none of the other choices apply)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Paste Link to the issue

• Connecting to MQTT broker spins when invalid authentication config #2728

Checklist

• I have read the CONTRIBUTING doc
• I have signed the CLA (in all commits with git commit -s)
• I ran cargo fmt as mentioned in CODING_GUIDELINES
• I used cargo clippy as mentioned in CODING_GUIDELINES
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

Further comments

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 76.6%. Comparing base (e7bf843) to head (c0b0f6a).
Report is 1 commits behind head on main.

Additional details and impacted files

Files	Coverage Δ
crates/common/mqtt_channel/src/connection.rs	60.0% <0.0%> (+4.4%)	⬆️

... and 3 files with indirect coverage changes

[didier-wenzek]

Approved

[github-actions]

Robot Results

✅ Passed	❌ Failed	⏭️ Skipped	Total	Pass %	⏱️ Duration
429	0	3	429	100	0s