Feat: improve workflow builtin actions #3105
Merged
Commits on Sep 11, 2024
-
Make the builtin action explicit
This commit introduces no changes to the user. This is only a preparation step to replace builtin actions, which usage was very restricted and specific, with builtin operations that can be used as any other operations. Signed-off-by: Didier Wenzek <[email protected]>
-
Clarify name and role of workflow processing methods
Signed-off-by: Didier Wenzek <[email protected]>
-
Use user provider exec and await handlers for builtin actions
Signed-off-by: Didier Wenzek <[email protected]>
-
Rename BgExitHandlers -> ExecHandlers
The new name is more appropriate, now that these handlers are used not only for background scripts but also to trigger a sub operation or a builtin action. Signed-off-by: Didier Wenzek <[email protected]>
-
Improve documentation of builtin actions in a workflow
Signed-off-by: Didier Wenzek <[email protected]>
-
Simplify operation workflow test
Signed-off-by: Didier Wenzek <[email protected]>
-
Signed-off-by: Didier Wenzek <[email protected]>
-
A builtin:operation can only be invoked from the same operation
Signed-off-by: Didier Wenzek <[email protected]>
-
Check that builtin actions are still supported even if deprecated
Signed-off-by: Didier Wenzek <[email protected]>
-
A builtin operation can be triggered on the executing step
Signed-off-by: Didier Wenzek <[email protected]>
-
Use T::try_from instead of TryInto::<T>::try_into
Signed-off-by: Didier Wenzek <[email protected]>
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.