-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Fix Rust 1.82 clippy lints #3195
Conversation
Signed-off-by: Marcel Guzik <[email protected]>
Robot Results
|
Signed-off-by: Marcel Guzik <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
/// Represents an "Entity topic identifier" portion of the MQTT topic | ||
/// | ||
/// Example: | ||
/// - topic: `te/device/dev1/service/myservice/m//my_measurement` | ||
/// - entity id: `device/dev1/service/myservice` | ||
/// | ||
/// <https://thin-edge.github.io/thin-edge.io/next/references/mqtt-api/#group-identifier> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to attach this definition to a type or a module, rather than remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is for EntityTopicId
. The struct was moved to another module along with the comment, but the comment in this module wasn't deleted.
thin-edge.io/crates/core/tedge_api/src/mqtt_topics.rs
Lines 275 to 292 in 0748986
/// Represents an "Entity topic identifier" portion of the MQTT topic | |
/// | |
/// An entity identifier is a fixed 4-segment group, as such any 4 topic | |
/// segments that come after the root are considered a part of an identifier, | |
/// even if they contain values usually present in the channel group, e.g. | |
/// `/m/`. | |
/// | |
/// If the topic ends before the expected 4 segments, the remaining segments are | |
/// filled by empty segments (`//`). | |
/// | |
/// # Example | |
/// - topic: `te/device/dev1/service/myservice/m//my_measurement` | |
/// - entity id: `device/dev1/service/myservice` | |
/// | |
/// # Reference | |
/// https://thin-edge.github.io/thin-edge.io/next/references/mqtt-api/#group-identifier | |
#[derive(Debug, Clone, Hash, PartialEq, Eq, Deserialize, Serialize)] | |
pub struct EntityTopicId(String); |
Proposed changes
Today, Rust 1.82 was published, which means there are new clippy lints breaking our CI that we get to fix. Yay 🎉
I also fixed lints present on nightly (1.84), so we should be good for a while.
Types of changes
Paste Link to the issue
Checklist
cargo fmt
as mentioned in CODING_GUIDELINEScargo clippy
as mentioned in CODING_GUIDELINESFurther comments