-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add system test for the SmartREST templates #3202
Draft
gligorisaev
wants to merge
2
commits into
thin-edge:main
Choose a base branch
from
gligorisaev:smartrest
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
68 changes: 68 additions & 0 deletions
68
tests/RobotFramework/tests/cumulocity/smartrest/smartrest_templates.robot
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,68 @@ | ||
*** Settings *** | ||
Resource ../../../resources/common.resource | ||
Library Cumulocity | ||
Library ThinEdgeIO | ||
|
||
Suite Setup Custom Setup | ||
Suite Teardown Get Logs | ||
|
||
|
||
*** Test Cases *** | ||
|
||
Add New SmartREST Template | ||
[Documentation] Test to add a new SmartREST template | ||
|
||
# Check if SmartREST template setting exists | ||
Verify Non-Existing SmartREST Templates | ||
|
||
# Add Template and check if it was added | ||
Execute Command sudo tedge config set c8y.smartrest.templates template-1 | ||
Check SmartREST Templates present template-1 | ||
|
||
# Add Template and check if existing template + added template co-exist | ||
Execute Command sudo tedge config add c8y.smartrest.templates template-2 | ||
Reconnect to Cumulocity | ||
Check SmartREST Templates present template-1 template-2 | ||
|
||
# Add Template using set command and check if setting was overwritten | ||
Execute Command sudo tedge config set c8y.smartrest.templates template-2,template-3 | ||
Reconnect to Cumulocity | ||
Check SmartREST Templates present template-2 template-3 | ||
Check SmartREST Templates not present template-1 | ||
|
||
Remove SmartREST Template | ||
[Documentation] Test to remove a SmartREST template | ||
Execute Command sudo tedge config remove c8y.smartrest.templates template-2 | ||
Reconnect to Cumulocity | ||
Check SmartREST Templates present template-3 | ||
Check SmartREST Templates not present template-2 | ||
|
||
# Remove all SmartREST templates using unset | ||
Execute Command sudo tedge config unset c8y.smartrest.templates | ||
Reconnect to Cumulocity | ||
Verify Non-Existing SmartREST Templates | ||
|
||
|
||
*** Keywords *** | ||
|
||
Custom Setup | ||
${DEVICE_SN}= Setup | ||
Set Suite Variable $DEVICE_SN | ||
|
||
Verify Non-Existing SmartREST Templates | ||
${output}= Execute Command tedge config get c8y.smartrest.templates | ||
Should Match Regexp ${output} ^\s*(\\[\\]|\bnone\b|null)\s*$ | ||
|
||
Reconnect to Cumulocity | ||
Execute Command sudo tedge reconnect c8y | ||
|
||
Check SmartREST Templates | ||
[Arguments] ${state} @{templates} | ||
${output}= Execute Command tedge config get c8y.smartrest.templates | ||
FOR ${template} IN @{templates} | ||
IF '${state}' == 'present' | ||
Should Contain ${output} ${template} | ||
ELSE IF '${state}' == 'not present' | ||
Should Not Contain ${output} ${template} | ||
END | ||
END |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tedge config will never returns
none
ornull
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thoughts behind this were instead of assuming the output will be [], to ensure the keyword can handle different potential outputs for no templates, making the test more robust, not for now but also in the future. I can change it to the state that I had before
Should Contain ${output} []
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
c8y.smartrest.templates
is a list of templates, hencenone
andnull
values are to be rejected as errors.