Add Heroku helper scripts #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion apps in a given team and pipeline.
whusterj
commented
Nov 9, 2024
| else | ||
| env_file="{{env_file}}" | ||
| fi |
There was a problem hiding this comment.
It's verbose, but I think I might like this as a standard pattern for tn-cli scripts. Here this recipe allows you to EITHER pass in your variables from the command line — in this case env_var and app_name — OR pass nothing and the script will prompt you for what it needs.
This could help with the documentation issue @oudeismetis brought up in #16. Because the prompts within the script can give users more context on what each variable means.
whusterj
commented
Nov 9, 2024
| function set_env() { | ||
| echo "Setting env vars from $env_file..." | ||
| [ -f "$env_file" ] && grep -vE '^(\s*$|#|DB_|REDIS_|ENVIRONMENT)' "$env_file" | tr '\n' ' ' | xargs heroku config:set -a $app_name || echo "Env file $env_file is not present, unable to set vars." |
There was a problem hiding this comment.
This departs from the tn-gist version by also protecting against overwriting the ENVIRONMENT variable on the app, which is set when the app is created.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What This Does
Adds some scripts that help accelerate Heroku setup.
These were already mostly written up in tn-gists, but this should help make them more accessible.
To Do
ALLOWED_HOSTS?heroku config:set NPM_CONFIG_PRODUCTION=falsesodevDependenciesare installed and the NodeJS build will succeed.