Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to port back from FRCG #61

Open
41 of 58 tasks
JulesKhong opened this issue Feb 26, 2024 · 1 comment
Open
41 of 58 tasks

Changes to port back from FRCG #61

JulesKhong opened this issue Feb 26, 2024 · 1 comment
Assignees

Comments

@JulesKhong
Copy link

JulesKhong commented Feb 26, 2024

Estimates

  • (8 hours) bring code changes back from FRCG, based on meetings with James and with Julie this week on "what is 'base'" (@JulesKhong )
  • [ 3 hours? ] Code review changes (@jamacon36)
  • [ 3 hours] make fixes based on code review (@JulesKhong or @jamacon36 )
  • (2 hours) QA fixes

Next step

Assets

  • Update css file structure to match atomic naming approach.
    Image
  • Update base JS functions with final versions

Tokens

  • Update button component file to bring in the rest of the base button styles
  • Update base grids file with abstracted gap values
  • Overall: update base token files to match finalized FRCG values and efficiencies
  • Add p-site to site-spacing.json
  • Add the rest of the base typography styles to match full set from FRCG
  • Ensure any new styles are included in /style-guide

Views

  • Update the views directory to match atomic naming conventions in FRCG
    Image
    Buttons
  • btn-dropdown
  • btn-social
  • btn-tag
  • btn-tag--checkbox
  • btn-text-link
  • btn-underline

SVGS

  • Add basic social svs, ensure social block is populated, add to style guide.

Cards

Update card styles to use the latest refinements from FRCG

  • Card-event
  • card-listing
  • card-md
  • card-lg
  • card-xl
  • card-overlay-link
  • card-person
  • example--card

Images

Bring over caption files so captions above/below functionality is working and has base styles

  • caption--below
  • caption--above
  • media

Pagination

Bring over base pagination

  • pagination.twig and pagination.css
  • Add it to index.css
  • ensure it's working on the style guide

Section title

  • Bring over updates from section title component across layouts, including new properties

Blocks

  • BANNER: Bring over banner updates, including video banner, default, fullBleed, homepage, insetCentered, overlay, and side-text. Ensure hero vs cta logic and h1 vs h2 logic is working.
  • Confirm js and css are still working on the style guide, and with video.
  • Card Grid block updates
  • CTA block updates
  • Image-text block updates
  • News grid block updates
  • people cards block updates
  • Ensure all blocks are appearing on the style guide, and are accessible with automated and manual testing

Footer

  • Port back footer and footer menu base work
  • add footer and footer menus to the style guide

Header

  • Port back header and header base menus (base and utility, desktop and mobile, submenus)
  • port back css and js, test to confirm accessibility is intact

Style guide sections directory

  • Update file structure to match atomic naming conventions from frcg

Image

Other

  • Update menu.twig
  • Update template directory file structure and naming conventions, and update all references in .php files

Image

  • Update 404.twig to have base styles
  • update pages/page-landing-page.twig
  • update posts/single.twig
  • update pages/page-style-guide.twig
  • update archive/archive.twig
  • update page/our-team.twig
@JulesKhong JulesKhong self-assigned this Feb 26, 2024
JulesKhong added a commit that referenced this issue Feb 29, 2024
JulesKhong added a commit that referenced this issue Feb 29, 2024
JulesKhong added a commit that referenced this issue Feb 29, 2024
JulesKhong added a commit that referenced this issue Feb 29, 2024
JulesKhong added a commit that referenced this issue Feb 29, 2024
JulesKhong added a commit that referenced this issue Feb 29, 2024
JulesKhong added a commit that referenced this issue Mar 8, 2024
JulesKhong added a commit that referenced this issue Mar 8, 2024
JulesKhong added a commit that referenced this issue Mar 8, 2024
JulesKhong added a commit that referenced this issue Mar 8, 2024
JulesKhong added a commit that referenced this issue Mar 8, 2024
JulesKhong added a commit that referenced this issue Mar 8, 2024
JulesKhong added a commit that referenced this issue Mar 8, 2024
JulesKhong added a commit that referenced this issue Mar 8, 2024
JulesKhong added a commit that referenced this issue Mar 8, 2024
JulesKhong added a commit that referenced this issue Mar 8, 2024
JulesKhong added a commit that referenced this issue Mar 9, 2024
JulesKhong added a commit that referenced this issue Mar 9, 2024
JulesKhong added a commit that referenced this issue Mar 9, 2024
JulesKhong added a commit that referenced this issue Mar 9, 2024
JulesKhong added a commit that referenced this issue Mar 9, 2024
JulesKhong added a commit that referenced this issue Mar 9, 2024
JulesKhong added a commit that referenced this issue Mar 9, 2024
JulesKhong added a commit that referenced this issue Mar 9, 2024
@JulesKhong JulesKhong mentioned this issue Mar 9, 2024
1 task
@bdimaggio
Copy link

bdimaggio commented Nov 5, 2024

@JulesKhong assuming the todos in this ticket are correct, what do you think is easiest to work with — I can pull each of the undone ones into their own tickets, you could finish them here, or...?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants