Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#61 Base changes #67

Open
wants to merge 315 commits into
base: main
Choose a base branch
from
Open

#61 Base changes #67

wants to merge 315 commits into from

Conversation

JulesKhong
Copy link

@JulesKhong JulesKhong commented Feb 29, 2024 •
edited
Loading

#61 This PR brings back base-level changes from FRCG. I sync'd with Julie to confirm what changes she wants to keep and what should be left as-is.

This PR also updates the directory structure in the WP base theme to use the atomic-structure.

Known bugs

  • The blocks stopped rendering on the style guide page, but they also aren't rendering on the site overall, so I don't know if it's a FE bug or BE. @jamacon36 Would you take a peek? Once they're rendering, I can tag back in to do QA on the blocks on the base blocks on the style guide page.

JulesKhong and others added 30 commits September 22, 2023 18:15
@JulesKhong
removes extra notes/fields
82dbc70
@JulesKhong
Moves Accordion to its own directory
83ab305
@JulesKhong
#20 Updates site padding
91bf493
@JulesKhong
#20 adds Image + Text block
278a434
@JulesKhong
#20 updates h5
5e13b81
@JulesKhong
#20 fixes svg margin on button-base
dada462
@JulesKhong
#20 updates default btn to lg
dbfb8bb
@JulesKhong
#20 adds two-up btn template, and image template
fc774e0
@JulesKhong
#20 adds Image + Text style guide examples
4f2d10a
@JulesKhong
Adds styles for CTA, updates a field config for colorway
a00c98b
@JulesKhong
Card grid added to the style guide
1db0cab
@JulesKhong
#21 adds heading and p style to Text block
b42a8fa
@jamacon36
merging
5847cbe
@jamacon36
continuing merge
a24ee35
@jamacon36
first pass at header nav
9f097e7
@jamacon36
adds colorway to grid block and ctas to header
d2dd80a
@jamacon36
Merge pull request #36 from thinkshout/header-nav
db947ff 
Header nav
@JulesKhong
Updates button colorways per Julie
7fe633d
@JulesKhong
Refactors btn-two-up to remove layout decisions
37e6c96
@JulesKhong
#20 Adds section-title component, refactors blocks to use it, adds it…
60a3758 
… to style guide
@JulesKhong
Updates default brand style to match Figma
7b2370e
@JulesKhong
#20 refactors card-grid to use section-title
d4e640b
@JulesKhong
Moves section-title to components directory
3890044
@jamacon36
removes flexible content components
0b7851a
@jamacon36
adds banner template
42678b4
@jamacon36
refactors blocks to use section title model fields
50509e5
@jamacon36
updates accordion example text
3224ec2
@jamacon36
updates wayfinding cards location
66867e1
@JulesKhong
#14 adds btn-icon, btn-dropdown, btn-hamburger
9a7553e
@JulesKhong
#14 adds ability to set other classes on btn-two-up
92b2319
JulesKhong added 26 commits March 7, 2024 21:28
@JulesKhong
#61 Moves wayfinding-cards display template
59f73e2
@JulesKhong
#61 fixes broken css variables
d006f86
@JulesKhong
#61 fixes teas.twig path reference
30dcefc
@JulesKhong
#61 removes people card JS logic
171a379
@JulesKhong
#61 updates JS for navigation
e24d0f2
@JulesKhong
#61 removes icon-link svg twig files
052cdd6
@JulesKhong
#61 updates page.twig to use an h1 banner
1045651
@JulesKhong
#61 adds pagination to /style-guide
98d40f7
@JulesKhong
#61 removes FRCG social links, replaces with TS
b049527
@JulesKhong
#61 removes FRCG contact info, adds placeholder
ac0ad55
@JulesKhong
#61 removes Amnesty reference
c9b0767
@JulesKhong
#61 updates grid approach in tokens and style guide
50dbef5
@JulesKhong
#61 renames styleguide-sections directory
be0b35a
@JulesKhong
#61 adds atomic approach to style guide page
9e8d8ec
@JulesKhong
#61 fixes directory paths on cards
f60ab2f
@JulesKhong
#61 fixes wrong secondary-900 color
e0a066e
@JulesKhong
#61 fixes wrong secondary-900 color
1fc19e1
@JulesKhong
#61 adds grid tokens to tailwind.config.js
4b68c3c
@JulesKhong
#61 adds page template to page.php
d77cca5
@JulesKhong
#61 recompiled _tokens.js
3f7f925
@JulesKhong
#61 adds event cards and fixes person card base
5b7eb87
@JulesKhong
#61 updates style guide section description documentation
2d14a08
@JulesKhong
#61 adds pagination to the style guide
ee16234
@JulesKhong
#61 updates directory path to menu.twig
98f303d
@JulesKhong
#61 adds Footer to style guide
9d685a2
@JulesKhong
#61 adds page-our-team.twig
0d6b2eb
@JulesKhong JulesKhong changed the title WIP #61 Base changes #61 Base changes Mar 9, 2024
@JulesKhong JulesKhong requested a review from jamacon36 March 9, 2024 03:33
@bdimaggio bdimaggio mentioned this pull request Nov 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamacon36 jamacon36 Awaiting requested review from jamacon36

Assignees

@jamacon36 jamacon36

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JulesKhong @jamacon36