Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InAppWallet -> Enclave #87

Merged
merged 6 commits into from
Nov 5, 2024
Merged

InAppWallet -> Enclave #87

merged 6 commits into from
Nov 5, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Oct 23, 2024

Merge when backend is ready


PR-Codex overview

This PR focuses on refactoring the InAppWallet and EcosystemWallet classes, enhancing the handling of user authentication methods, and improving the structure of linked account management.

Detailed summary

  • Changed User to null in EmbeddedWallet.
  • Updated SendPhoneOtpAsync and SendEmailOtpAsync methods to remove return values.
  • Introduced UserStatusResponse and LinkedAccount structures.
  • Refactored methods to use properties instead of private fields in EcosystemWallet.
  • Adjusted error handling and validation in authentication methods.
  • Enhanced GetLinkedAccounts and LinkAccount methods for better readability and performance.
  • Updated documentation for clarity on parameters and return types.
  • Improved method signatures for consistency across classes.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Merge when backend is ready
@0xFirekeeper 0xFirekeeper merged commit 19d4307 into main Nov 5, 2024
1 check failed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/iaw-to-eco branch November 5, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant