Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve NFT Metadata & Filters #99

Merged
merged 3 commits into from
Nov 15, 2024

Conversation

0xFirekeeper
Copy link
Member

@0xFirekeeper 0xFirekeeper commented Nov 12, 2024

PR-Codex overview

This PR focuses on enhancing the functionality of ERC721 and ERC1155 NFT contracts by adding options to retrieve owner details and supply information. It also updates test cases to reflect these changes.

Detailed summary

  • Updated XML documentation to clarify applicability for ERC721 and ERC1155.
  • Modified Owner and QuantityOwned properties in NFT struct.
  • Added fillOwner parameter to ERC721_GetNFT and ERC721_GetAllNFTs methods.
  • Added fillSupply parameter to ERC1155_GetNFT and ERC1155_GetAllNFTs methods.
  • Updated tests to check for owner and supply details based on new parameters.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 55.17241% with 13 lines in your changes missing coverage. Please review.

Project coverage is 78.09%. Comparing base (1fef151) to head (b4eade9).

Files with missing lines Patch % Lines
Thirdweb/Thirdweb.Extensions/ThirdwebExtensions.cs 55.17% 12 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #99      +/-   ##
==========================================
+ Coverage   77.92%   78.09%   +0.17%     
==========================================
  Files          28       28              
  Lines        4375     4387      +12     
  Branches      611      614       +3     
==========================================
+ Hits         3409     3426      +17     
+ Misses        800      797       -3     
+ Partials      166      164       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@0xFirekeeper 0xFirekeeper merged commit 957b895 into main Nov 15, 2024
1 check passed
@0xFirekeeper 0xFirekeeper deleted the firekeeper/improved-nft-metadata-filters branch November 15, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants