Skip to content

[react, react-native] Fix double connection issue, add ConnectEmbed component #7563

[react, react-native] Fix double connection issue, add ConnectEmbed component

[react, react-native] Fix double connection issue, add ConnectEmbed component #7563

Re-run triggered January 10, 2024 11:58
Status Failure
Total duration 1m 51s
Artifacts
This run and associated checks have been archived and are scheduled for deletion. Learn more about checks retention

build-test-lint.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 4 warnings
E2E Tests
bundlers-webpack#e2e: command (/home/runner/work/js/js/test/bundlers/webpack) pnpm run e2e exited (1)
E2E Tests
Process completed with exit code 1.
Lint Packages: packages/react/src/payments/components/CheckoutWithCard.tsx#L100
React Hook useEffect has missing dependencies: 'appNameToUse', 'clientId', 'configs', 'locale', 'onBeforeModalOpen', 'onCardDetailLoad', 'onError', 'onPaymentSuccess', 'onPriceUpdate', 'onReview', 'options', and 'sdkClientSecret'. Either include them or remove the dependency array. Mutable values like 'CheckoutWithCardIframeContainerRef.current' aren't valid dependencies because mutating them doesn't re-render the component
Lint Packages: packages/react/src/payments/components/PaperCheckout.tsx#L144
React Hook useEffect has missing dependencies: 'onCloseCheckout', 'onPaymentSuccess', and 'onTransferSuccess'. Either include them or remove the dependency array. If 'onPaymentSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback
Lint Packages: packages/react/src/payments/components/VerifyOwnershipWithPaper.tsx#L87
React Hook useEffect has missing dependencies: 'onError', 'onSuccess', and 'onWindowClose'. Either include them or remove the dependency array. If 'onSuccess' changes too often, find the parent component that defines it and wrap that definition in useCallback
Lint Packages: packages/react/src/payments/components/common/Modal.tsx#L39
React Hook useEffect has missing dependencies: 'escapeToClose' and 'onClose'. Either include them or remove the dependency array. If 'onClose' changes too often, find the parent component that defines it and wrap that definition in useCallback