Skip to content

Commit

Permalink
[SDK] chore: Re-enable flaky smart wallet tests (#6369)
Browse files Browse the repository at this point in the history
<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on addressing flaky tests in the `thirdweb` codebase by enabling previously skipped tests related to `SmartWallet` functionality, ensuring they are executed as part of the test suite.

### Detailed summary
- Removed `.github/workflows/issue.yml`.
- Enabled `describe` and `test` blocks previously marked as skipped in:
  - `smart-wallet-modular.test.ts`
  - `verify-typed-data.test.ts`
  - `smart-wallet-integration-v07.test.ts`
- Adjusted test configurations by removing `FIMXE` comments and retry limits.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
  • Loading branch information
joaquim-verges committed Feb 28, 2025
1 parent c4e7f3b commit e1f73c8
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 63 deletions.
49 changes: 0 additions & 49 deletions .github/workflows/issue.yml

This file was deleted.

6 changes: 2 additions & 4 deletions packages/thirdweb/src/auth/verify-typed-data.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("verifyTypedData", async () => {
).toBe(true);
});

// FIXME: flaky test - needs to be fixed
test.skip("invalid EOA signature", async () => {
test("invalid EOA signature", async () => {
expect(
await verifyTypedData({
...typedData.basic,
Expand All @@ -54,8 +53,7 @@ describe.runIf(process.env.TW_SECRET_KEY)("verifyTypedData", async () => {
).toBe(true);
});

// FIXME: flaky test - needs to be fixed
test.skip("invalid smart account signature", async () => {
test("invalid smart account signature", async () => {
expect(
await verifyTypedData({
...typedData.basic,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,9 @@ const contract = getContract({
address: "0xe2cb0eb5147b42095c2FfA6F7ec953bb0bE347D8",
});

// FIXME: SKIP ALL OF THIS IT IS FLAKY
describe.skip(
describe.sequential(
"SmartWallet 0.7 core tests",
{
retry: 0,
timeout: 240_000,
},
() => {
Expand Down Expand Up @@ -103,8 +101,7 @@ describe.skip(
expect(isValid).toEqual(true);
});

// FIXME: flaky test - skipped
it.skip("should use ERC-1271 signatures after deployment", async () => {
it("should use ERC-1271 signatures after deployment", async () => {
await deploySmartAccount({
chain,
client,
Expand Down Expand Up @@ -137,8 +134,7 @@ describe.skip(
expect(isValid).toEqual(true);
});

// FIXME: flaky test - skipped
it.skip("should use ERC-1271 typed data signatures after deployment", async () => {
it("should use ERC-1271 typed data signatures after deployment", async () => {
await deploySmartAccount({
chain,
client,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ const factoryAddress = "0x564cf6453a1b0FF8DB603E92EA4BbD410dea45F3"; // pre 712
describe.runIf(process.env.TW_SECRET_KEY).sequential(
"SmartWallet core tests",
{
retry: 0,
timeout: 240_000,
},
() => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ const client = TEST_CLIENT;
const DEFAULT_FACTORY_ADDRESS = "0xB1846E893CA01c5Dcdaa40371C1e13f2e0Df5717";
const DEFAULT_VALIDATOR_ADDRESS = "0x7D3631d823e0De311DC86f580946EeF2eEC81fba";

// FIXME: This test is flaky and needs to be fixed
describe.skip.sequential(
describe.sequential(
"SmartWallet modular tests",
{
retry: 0,
Expand Down

0 comments on commit e1f73c8

Please sign in to comment.