Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add hideDisconnect prop to ConnectWallet #2122

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

b-bot
Copy link
Contributor

@b-bot b-bot commented Jan 5, 2024

Problem solved

Allows hiding of "Disconnect Wallet" button useful for controlling connection lifecycle programmatically.

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: explain the internal logic changes

How to test

  • Automated tests: link to unit test file
  • Manual tests: step by step instructions on how to test

@b-bot b-bot requested a review from a team as a code owner January 5, 2024 19:25
@b-bot b-bot requested a review from a team January 5, 2024 19:25
Copy link

changeset-bot bot commented Jan 5, 2024

🦋 Changeset detected

Latest commit: b211370

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@thirdweb-dev/react Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MananTank
Copy link
Member

Hi, @b-bot - Thanks for the contribution.

Can you add more details on what exactly are you trying to implement with this? Note that user can also disconnect wallet outside of the app - directly from wallet extension.

@b-bot
Copy link
Contributor Author

b-bot commented Jan 5, 2024

@MananTank Sure np.
Please see here: #2118

Under this flow the user would not have a wallet extension installed at all so cannot disconnect from there.

@MananTank
Copy link
Member

LGTM @b-bot - Thanks for contributing! 🎉

@joaquim-verges joaquim-verges merged commit 0ff90b8 into thirdweb-dev:main Jan 9, 2024
@github-actions github-actions bot mentioned this pull request Jan 9, 2024
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
* update infastructure to engine

* thirdweb.png replace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants