Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wallets] fix gas estimations for local and embedded wallets #2143

Merged
merged 3 commits into from
Jan 10, 2024

Conversation

joaquim-verges
Copy link
Member

Problem solved

For local/embedded wallets, we weren't using our custom gas estimation

Changes made

  • Public API changes: list the public API changes made if any
  • Internal API changes: wrapped signers to override sendTransaction, getDefaultOverrides now always return regardless of browser context

How to test

  • Automated tests: link to unit test file
  • Manual tests: tested in react app + dashboard

@joaquim-verges joaquim-verges requested a review from a team January 10, 2024 20:39
Copy link

changeset-bot bot commented Jan 10, 2024

🦋 Changeset detected

Latest commit: d69a1e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@thirdweb-dev/wallets Patch
@thirdweb-dev/sdk Patch
@thirdweb-dev/auth Patch
thirdweb Patch
@thirdweb-dev/react-core Patch
@thirdweb-dev/react-native Patch
@thirdweb-dev/react Patch
@thirdweb-dev/unity-js-bridge Patch
@thirdweb-dev/react-native-compat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@joaquim-verges
Copy link
Member Author

/release-pr

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (bbc2e09) 67.47% compared to head (7b32947) 67.51%.
Report is 11 commits behind head on main.

❗ Current head 7b32947 differs from pull request most recent head d69a1e3. Consider uploading reports for the commit d69a1e3 to get more accurate results

Files Patch % Lines
packages/sdk/src/evm/core/wallet/user-wallet.ts 25.00% 2 Missing and 1 partial ⚠️
.../src/evm/core/classes/internal/contract-wrapper.ts 33.33% 1 Missing and 1 partial ⚠️
packages/sdk/src/evm/core/classes/transactions.ts 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2143      +/-   ##
==========================================
+ Coverage   67.47%   67.51%   +0.03%     
==========================================
  Files         292      291       -1     
  Lines       11017    11011       -6     
  Branches     1512     1512              
==========================================
  Hits         7434     7434              
+ Misses       2961     2953       -8     
- Partials      622      624       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaquim-verges joaquim-verges added this pull request to the merge queue Jan 10, 2024
@joaquim-verges joaquim-verges removed this pull request from the merge queue due to a manual request Jan 10, 2024
@joaquim-verges joaquim-verges added this pull request to the merge queue Jan 10, 2024
Merged via the queue into main with commit 27c00ef Jan 10, 2024
6 checks passed
@joaquim-verges joaquim-verges deleted the joaquim/fix_ew_gas branch January 10, 2024 22:41
@github-actions github-actions bot mentioned this pull request Jan 10, 2024
jnsdls pushed a commit that referenced this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant