alpha

[jnsdls]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 4a03d61

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (beta@6cbff02). Click here to learn what that means.

❗ Current head 76d48ae differs from pull request most recent head 4a03d61. Consider uploading reports for the commit 4a03d61 to get more accurate results

Additional details and impacted files

@@           Coverage Diff           @@
##             beta    #2154   +/-   ##
=======================================
  Coverage        ?   27.11%           
=======================================
  Files           ?      672           
  Lines           ?    47554           
  Branches        ?     1961           
=======================================
  Hits            ?    12893           
  Misses          ?    34018           
  Partials        ?      643           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[socket-security]

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report↗︎

[socket-security]

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@changesets/[email protected]	environment, filesystem, shell Transitive: eval, unsafe	+299	28.5 MB	changesets-release-bot
npm/@coinbase/[email protected]	Transitive: environment, eval, filesystem, network, shell	+117	33.9 MB	coinbase-jake
npm/@emotion/[email protected]	environment Transitive: filesystem, unsafe	+60	7.82 MB	emotion-release-bot
npm/@manypkg/[email protected]	environment, filesystem Transitive: eval, network, shell	+108	3.3 MB	manypkg-release-bot
npm/@size-limit/[email protected]	Transitive: environment, eval, filesystem, network, shell, unsafe	+204	41.1 MB	ai
npm/@tanstack/[email protected]	Transitive: environment, eval, filesystem, shell, unsafe	+128	46.5 MB	tannerlinsley
npm/@tanstack/[email protected]	Transitive: environment	+4	4.08 MB	nksaraf, tannerlinsley
npm/@trivago/[email protected]	Transitive: environment, filesystem, unsafe	+41	22.4 MB	behraang
npm/@types/[email protected]	None	+5	8.34 MB	types
npm/@types/[email protected]	None	+1	3.96 MB	types
npm/@viem/[email protected]	network Transitive: environment, filesystem, shell	+27	1.73 MB	awkweb
npm/@vitest/[email protected]	Transitive: environment, filesystem, network, shell, unsafe	+117	24.7 MB	antfu, oreanno, patak, ...1 more
npm/@walletconnect/[email protected]	Transitive: environment, eval, filesystem, network, shell, unsafe	+231	42.5 MB	gancho_walletconnect
npm/[email protected]	None	+2	33.8 MB	awkweb
npm/[email protected]	environment, filesystem	+2	154 kB	marcocesarato
npm/[email protected]	filesystem Transitive: environment, eval, shell, unsafe	+112	13.6 MB	gajus
npm/[email protected]	network	+7	19.6 MB	ricmoo
npm/[email protected]	environment, filesystem, shell, unsafe Transitive: network	+222	48 MB	webpro
npm/[email protected]	Transitive: environment, network	+13	43.7 MB	jmoxey
npm/[email protected]	environment, eval, filesystem	+71	4.92 MB	joshuakgoldberg
npm/[email protected]	environment, filesystem, unsafe	0	8.39 MB	prettier-bot
npm/[email protected]	environment, filesystem Transitive: shell	+34	3.22 MB	isaacs
npm/[email protected]	Transitive: environment, filesystem	+34	831 kB	ai
npm/[email protected]	None	0	30.6 kB	turbobot
npm/[email protected]	Transitive: environment, filesystem, network	+11	52 MB	typedoc-bot
npm/[email protected]	None	0	72 kB	antfu
npm/[email protected]	Transitive: environment, network	+12	45.5 MB	awkweb, jmoxey
npm/[email protected]	Transitive: environment, filesystem, network, shell, unsafe	+74	16.2 MB	antfu, oreanno, patak, ...1 more

🚮 Removed packages: npm/@changesets/[email protected], npm/@manypkg/[email protected], npm/@trivago/[email protected], npm/@vitejs/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

[jxom]

I am curious if the benchmarks bust the LRU caches per iteration (or iterations are not pure) to reflect a fair and real world comparison?

Update: we added this to isAddress recently, but just realised we didn’t update benchmarks to reflect - we can update that on our side.

[jnsdls]

we're #2356 now

[jnsdls]

I am curious if the benchmarks bust the LRU caches per iteration (or iterations are not pure) to reflect a fair and real world comparison?

Update: we added this to isAddress recently, but just realised we didn’t update benchmarks to reflect - we can update that on our side.

this is something I need to take a look at, good shout. We'll definitely want to do it (at least in the) "cold cache" benches