[CI] Chore: Only run actions for contributors #5739

gregfromstl · 2024-12-13T21:38:56Z

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR updates GitHub Actions workflows to enhance pull request handling by adding conditions for author associations and expanding the issue types that trigger actions.

Detailed summary

In .github/workflows/auto-assign.yml:
- Added conditions to the assign-author job to check if the author is a MEMBER, OWNER, or COLLABORATOR.
In .github/workflows/issue.yml:
- Expanded the types of pull requests that trigger actions to include ready_for_review.
- Added logic to automatically pass checks for external contributors.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

linear · 2024-12-13T21:38:58Z

CNCT-2678 Disable GH actions for external contributors

changeset-bot · 2024-12-13T21:39:00Z

⚠️ No Changeset found

Latest commit: dc1e07b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel · 2024-12-13T21:39:00Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs-v2	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 14, 2024 5:41pm
thirdweb_playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 14, 2024 5:41pm
thirdweb-www	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 14, 2024 5:41pm
wallet-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 14, 2024 5:41pm

graphite-app · 2024-12-13T21:39:02Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

merge-queue - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

codecov · 2024-12-13T21:40:38Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.01%. Comparing base (2b5080d) to head (dc1e07b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5739   +/-   ##
=======================================
  Coverage   53.01%   53.01%           
=======================================
  Files        1101     1101           
  Lines       59079    59079           
  Branches     4809     4809           
=======================================
  Hits        31322    31322           
  Misses      27039    27039           
  Partials      718      718

Flag	Coverage Δ		*Carryforward flag
legacy_packages	`65.68% <ø> (ø)`		Carriedforward from 2b5080d
packages	`50.15% <ø> (ø)`

*This pull request uses carry forward flags. Click here to find out more.

github-actions · 2024-12-13T21:42:23Z

size-limit report 📦

Path	Size	Loading time (3g)	Running time (snapdragon)	Total time
thirdweb (esm)	44.94 KB (0%)	899 ms (0%)	3.5 s (+58.64% 🔺)	4.4 s
thirdweb (cjs)	110.78 KB (0%)	2.3 s (0%)	6.1 s (+16.91% 🔺)	8.3 s
thirdweb (minimal + tree-shaking)	5.58 KB (0%)	112 ms (0%)	211 ms (-27.76% 🔽)	323 ms
thirdweb/chains (tree-shaking)	506 B (0%)	10 ms (0%)	55 ms (-18.93% 🔽)	65 ms
thirdweb/react (minimal + tree-shaking)	19.03 KB (0%)	381 ms (0%)	577 ms (+19.44% 🔺)	958 ms

graphite-app · 2024-12-13T21:44:34Z

.github/workflows/auto-assign.yml

+            const { exec } = require('child_process');
+            exec('npx @toshimaru/auto-author-assign');


Running npx via exec() is error-prone since it won't properly propagate failures to the workflow. A more reliable approach is to use the GitHub Action directly with a conditional:

- uses: toshimaru/[email protected] if: ${{ github.event.pull_request.author_association == 'MEMBER' || github.event.pull_request.author_association == 'OWNER' || github.event.pull_request.author_association == 'COLLABORATOR' }}

This ensures proper error handling and maintains the original functionality.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

gregfromstl · 2024-12-14T17:38:14Z

Merge activity

Dec 14, 12:38 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Dec 14, 12:38 PM EST: A user added this pull request to the Graphite merge queue.
Dec 14, 12:42 PM EST: A user merged this pull request with the Graphite merge queue.

## Problem solved Short description of the bug fixed or feature added  --- ## PR-Codex overview This PR enhances the GitHub workflows for pull requests by adding conditions for author associations and expanding issue types. ### Detailed summary - In `.github/workflows/auto-assign.yml`, added checks to assign authors only if they are `MEMBER`, `OWNER`, or `COLLABORATOR`. - In `.github/workflows/issue.yml`, expanded the `types` to include `ready_for_review`. - Added logic to automatically pass checks for external contributors. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

gregfromstl requested review from jnsdls and joaquim-verges as code owners December 13, 2024 21:38

vercel bot deployed to Preview – wallet-ui December 13, 2024 21:39 View deployment

vercel bot deployed to Preview – thirdweb_playground December 13, 2024 21:39 View deployment

github-actions bot assigned gregfromstl Dec 13, 2024

vercel bot deployed to Preview – docs-v2 December 13, 2024 21:39 View deployment

vercel bot deployed to Preview – thirdweb-www December 13, 2024 21:41 View deployment

gregfromstl force-pushed the greg/cnct-2678-disable-gh-actions-for-external-contributors branch from 3f13a3c to 8ed4558 Compare December 13, 2024 21:42

vercel bot deployed to Preview – wallet-ui December 13, 2024 21:43 View deployment

vercel bot deployed to Preview – thirdweb_playground December 13, 2024 21:43 View deployment

graphite-app bot reviewed Dec 13, 2024

View reviewed changes

vercel bot deployed to Preview – docs-v2 December 13, 2024 21:44 View deployment

vercel bot deployed to Preview – thirdweb-www December 13, 2024 21:46 View deployment

gregfromstl force-pushed the greg/cnct-2678-disable-gh-actions-for-external-contributors branch from 8ed4558 to 04b278c Compare December 13, 2024 21:49

vercel bot deployed to Preview – wallet-ui December 13, 2024 21:50 View deployment

vercel bot deployed to Preview – thirdweb_playground December 13, 2024 21:50 View deployment

vercel bot deployed to Preview – docs-v2 December 13, 2024 21:51 View deployment

vercel bot deployed to Preview – thirdweb-www December 13, 2024 21:52 View deployment

joaquim-verges approved these changes Dec 14, 2024

View reviewed changes

gregfromstl added the merge-queue Adds the pull request to Graphite's merge queue. label Dec 14, 2024

gregfromstl force-pushed the greg/cnct-2678-disable-gh-actions-for-external-contributors branch from 04b278c to dc1e07b Compare December 14, 2024 17:38

vercel bot deployed to Preview – wallet-ui December 14, 2024 17:40 View deployment

vercel bot deployed to Preview – thirdweb_playground December 14, 2024 17:40 View deployment

vercel bot deployed to Preview – docs-v2 December 14, 2024 17:40 View deployment

vercel bot deployed to Preview – thirdweb-www December 14, 2024 17:41 View deployment

graphite-app bot merged commit dc1e07b into main Dec 14, 2024
31 checks passed

graphite-app bot deleted the greg/cnct-2678-disable-gh-actions-for-external-contributors branch December 14, 2024 17:42

vercel bot deployed to Production – wallet-ui December 14, 2024 17:43 View deployment

vercel bot deployed to Production – thirdweb_playground December 14, 2024 17:43 View deployment

vercel bot deployed to Production – docs-v2 December 14, 2024 17:44 View deployment

vercel bot deployed to Production – thirdweb-www December 14, 2024 17:45 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CI] Chore: Only run actions for contributors #5739

[CI] Chore: Only run actions for contributors #5739

gregfromstl commented Dec 13, 2024 •

edited by pr-codex bot

Loading

linear bot commented Dec 13, 2024

changeset-bot bot commented Dec 13, 2024 •

edited

Loading

vercel bot commented Dec 13, 2024 •

edited

Loading

graphite-app bot commented Dec 13, 2024

codecov bot commented Dec 13, 2024 •

edited

Loading

github-actions bot commented Dec 13, 2024 •

edited

Loading

graphite-app bot Dec 13, 2024

gregfromstl commented Dec 14, 2024 •

edited by graphite-app bot

Loading

		const { exec } = require('child_process');
		exec('npx @toshimaru/auto-author-assign');

[CI] Chore: Only run actions for contributors #5739

[CI] Chore: Only run actions for contributors #5739

Conversation

gregfromstl commented Dec 13, 2024 • edited by pr-codex bot Loading

Problem solved

PR-Codex overview

Detailed summary

linear bot commented Dec 13, 2024

changeset-bot bot commented Dec 13, 2024 • edited Loading

⚠️ No Changeset found

vercel bot commented Dec 13, 2024 • edited Loading

graphite-app bot commented Dec 13, 2024

How to use the Graphite Merge Queue

codecov bot commented Dec 13, 2024 • edited Loading

Codecov Report

github-actions bot commented Dec 13, 2024 • edited Loading

size-limit report 📦

graphite-app bot Dec 13, 2024

Choose a reason for hiding this comment

gregfromstl commented Dec 14, 2024 • edited by graphite-app bot Loading

Merge activity

gregfromstl commented Dec 13, 2024 •

edited by pr-codex bot

Loading

changeset-bot bot commented Dec 13, 2024 •

edited

Loading

vercel bot commented Dec 13, 2024 •

edited

Loading

codecov bot commented Dec 13, 2024 •

edited

Loading

github-actions bot commented Dec 13, 2024 •

edited

Loading

gregfromstl commented Dec 14, 2024 •

edited by graphite-app bot

Loading