-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Feature: Deploy typedoc to permalink #5740
[CI] Feature: Deploy typedoc to permalink #5740
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
3c1ee63
to
4a016e7
Compare
size-limit report 📦
|
da934bf
to
2f539dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
interesting! want to see what this looks like
.github/workflows/typedoc.yml
Outdated
} | ||
}); | ||
|
||
console.log(`Permalink: https://gist.githubusercontent.com/raw/${gistId}/data.json`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The console.log
statement appears to be misaligned and should be moved inside the script
block. Currently it's at the root level of the with
block, which will cause a syntax error. Moving it inside the script and aligning it with the rest of the code will resolve this issue:
script: |
const fs = require('fs');
// ... rest of the code ...
console.log(`Permalink: https://gist.githubusercontent.com/${gistId}/data.json`);
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
.github/workflows/typedoc.yml
Outdated
- name: Generate Documentation | ||
run: pnpm typedoc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The generated documentation needs to be published to GitHub Pages. Please add two steps after the Generate Documentation
step:
- Use
actions/upload-pages-artifact
to upload the TypeDoc output - Use
actions/deploy-pages
to deploy the artifact
This will ensure the documentation is accessible via GitHub Pages. Here's a reference implementation:
- name: Upload Pages artifact
uses: actions/upload-pages-artifact@v2
with:
path: typedoc/
- name: Deploy to GitHub Pages
uses: actions/deploy-pages@v3
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
2f539dd
to
80b6390
Compare
80b6390
to
a63d28e
Compare
d3e91a7
to
25ff6de
Compare
25ff6de
to
01ab0aa
Compare
01ab0aa
to
277fa72
Compare
Merge activity
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5740 +/- ##
=======================================
Coverage 53.01% 53.02%
=======================================
Files 1101 1101
Lines 59079 59079
Branches 4809 4810 +1
=======================================
+ Hits 31322 31327 +5
+ Misses 27039 27034 -5
Partials 718 718
*This pull request uses carry forward flags. Click here to find out more. |
<!-- start pr-codex --> ## PR-Codex overview This PR introduces a new `TypeDoc` workflow for generating documentation and updates the `parse.mjs` script to process documentation data. It also modifies the `package.json` to include the `typedoc-better-json` dependency and adjusts the `pnpm-lock.yaml` accordingly. ### Detailed summary - Added `TypeDoc` GitHub Actions workflow in `.github/workflows/typedoc.yml`. - Created a new `parse.mjs` script in `packages/thirdweb/scripts` for transforming documentation data. - Updated `package.json` to include `typedoc-better-json` as a dependency. - Adjusted `pnpm-lock.yaml` to reflect changes in dependencies and versions. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
277fa72
to
f91f631
Compare
PR-Codex overview
This PR introduces a script to parse TypeDoc output and a GitHub Actions workflow for generating and updating documentation. It also updates the
package.json
andpnpm-lock.yaml
files to include new dependencies and scripts.Detailed summary
parse.mjs
script to read, transform, and save TypeDoc JSON data..github/workflows/typedoc.yml
for automated TypeDoc generation and Gist update.package.json
to includetypedoc-better-json
and new scripts.pnpm-lock.yaml
to reflect changes in dependencies.