Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Reorganize portal landing page sections #5745

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Dec 16, 2024

Problem solved

Fixes XPROD-942


PR-Codex overview

This PR focuses on refining the ConnectCard component, updating the sidebar structure, and enhancing the page layout by introducing new sections and modifying existing ones. It also removes outdated code and improves the organization of the API references.

Detailed summary

  • Added isExternal prop to the ConnectCard in Cards/ConnectCard.tsx.
  • Updated sidebar structure by removing the "Quickstart" entry and refactoring API references.
  • Introduced new sections: FrontendSection, BackendSection, and Onchain.
  • Replaced "Templates" with "Starter Kits & demos" in page.mdx.
  • Removed commented-out tutorial components in page.tsx.
  • Streamlined the layout and improved organization of content across various sections.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Dec 16, 2024

⚠️ No Changeset found

Latest commit: f6d5d10

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 1:30am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
thirdweb_playground ⬜️ Skipped (Inspect) Dec 18, 2024 1:30am
thirdweb-www ⬜️ Skipped (Inspect) Dec 18, 2024 1:30am
wallet-ui ⬜️ Skipped (Inspect) Dec 18, 2024 1:30am

@vercel vercel bot temporarily deployed to Preview – wallet-ui December 16, 2024 02:17 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 16, 2024 02:17 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 16, 2024 02:17 Inactive
@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Dec 16, 2024
@joaquim-verges joaquim-verges marked this pull request as ready for review December 16, 2024 02:17
@joaquim-verges joaquim-verges requested a review from a team as a code owner December 16, 2024 02:17
@joaquim-verges joaquim-verges requested a review from a team December 16, 2024 02:17
@joaquim-verges joaquim-verges requested a review from a team as a code owner December 16, 2024 02:17
Copy link
Member Author

joaquim-verges commented Dec 16, 2024


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.02%. Comparing base (ecb4571) to head (f6d5d10).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5745      +/-   ##
==========================================
+ Coverage   52.99%   53.02%   +0.03%     
==========================================
  Files        1102     1101       -1     
  Lines       59107    59080      -27     
  Branches     4809     4810       +1     
==========================================
+ Hits        31323    31328       +5     
+ Misses      27066    27034      -32     
  Partials      718      718              
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from ecb4571
packages 50.16% <ø> (+0.03%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 4 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Dec 16, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.94 KB (0%) 899 ms (0%) 471 ms (+103.4% 🔺) 1.4 s
thirdweb (cjs) 110.85 KB (0%) 2.3 s (0%) 800 ms (+22.44% 🔺) 3.1 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 127 ms (+290.75% 🔺) 238 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 14 ms (-22.94% 🔽) 24 ms
thirdweb/react (minimal + tree-shaking) 19.07 KB (0%) 382 ms (0%) 161 ms (+76.48% 🔺) 542 ms

@joaquim-verges joaquim-verges force-pushed the feat_Reorganize_portal_landing_page_sections branch from b9fa932 to 276da55 Compare December 18, 2024 00:22
@joaquim-verges joaquim-verges requested review from jakubkrehel and a team as code owners December 18, 2024 00:22
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 18, 2024 00:23 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 18, 2024 00:23 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 18, 2024 00:23 Inactive
@joaquim-verges joaquim-verges force-pushed the feat_Reorganize_portal_landing_page_sections branch from 276da55 to f6d5d10 Compare December 18, 2024 01:22
@vercel vercel bot temporarily deployed to Preview – wallet-ui December 18, 2024 01:22 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground December 18, 2024 01:22 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www December 18, 2024 01:22 Inactive
Copy link

linear bot commented Dec 18, 2024

@joaquim-verges joaquim-verges merged commit 80faf34 into main Dec 18, 2024
32 of 42 checks passed
@joaquim-verges joaquim-verges deleted the feat_Reorganize_portal_landing_page_sections branch December 18, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Portal Involves changes to the Portal (docs) codebase.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants