Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration to enclave wallets in react native #5746

Merged

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Dec 16, 2024

Problem solved

Short description of the bug fixed or feature added


PR-Codex overview

This PR focuses on patching the thirdweb package and downgrading AWS libraries in the @thirdweb-dev/react-native-adapter. It includes updates to constants, package dependencies, and adjustments in the lock file.

Detailed summary

  • Patches thirdweb with a fix for migration to enclave in React Native.
  • Downgrades AWS libraries in @thirdweb-dev/react-native-adapter from 3.709.0 to 3.592.0.
  • Changes ENCLAVE_KMS_KEY_ARN constant in packages/thirdweb/src/wallets/in-app/native/helpers/constants.ts.
  • Updates files field format in packages/react-native-adapter/package.json.
  • Adjusts dependencies in pnpm-lock.yaml for consistent versioning.

The following files were skipped due to too many changes: pnpm-lock.yaml

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 11:16am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 11:16am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 11:16am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 16, 2024 11:16am

Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: 3c23bb2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
thirdweb Patch
@thirdweb-dev/react-native-adapter Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Dec 16, 2024
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges changed the title Fix migration to enclave walelts in react native Fix migration to enclave wallets in react native Dec 16, 2024
@joaquim-verges joaquim-verges marked this pull request as ready for review December 16, 2024 11:06
Copy link

Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 44.94 KB (0%) 899 ms (0%) 2.8 s (+8.41% 🔺) 3.7 s
thirdweb (cjs) 110.78 KB (0%) 2.3 s (0%) 7.6 s (+31.69% 🔺) 9.8 s
thirdweb (minimal + tree-shaking) 5.58 KB (0%) 112 ms (0%) 213 ms (-24.4% 🔽) 325 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 137 ms (-14.49% 🔽) 147 ms
thirdweb/react (minimal + tree-shaking) 19.03 KB (0%) 381 ms (0%) 880 ms (-14.05% 🔽) 1.3 s

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.02%. Comparing base (0ddc123) to head (3c23bb2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5746   +/-   ##
=======================================
  Coverage   53.02%   53.02%           
=======================================
  Files        1101     1101           
  Lines       59079    59079           
  Branches     4810     4810           
=======================================
  Hits        31327    31327           
  Misses      27034    27034           
  Partials      718      718           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 0ddc123
packages 50.16% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@joaquim-verges joaquim-verges merged commit e42ffc6 into main Dec 16, 2024
32 of 36 checks passed
@joaquim-verges joaquim-verges deleted the 12-17-fix_migration_to_enclave_walelts_in_react_native branch December 16, 2024 11:27
@pr-codex pr-codex bot mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant