Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[thirdweb] deps: Upgrade viem to 2.23.5 #6336

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Feb 25, 2025


PR-Codex overview

This PR focuses on updating dependencies and ensuring compatibility with new versions, particularly for viem, while also adjusting size limits and peer dependencies in various configuration files.

Detailed summary

  • Updated viem version from 2.22.17 to 2.23.5 in package.json, .size-limit.json, and pnpm-lock.yaml.
  • Increased size limit in .size-limit.json from 130 kB to 131 kB.
  • Adjusted peer dependencies for various packages to maintain compatibility.
  • Enhanced dependency definitions in pnpm-lock.yaml, including nested dependencies for @aws-sdk packages and others.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 10:38am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 10:38am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 10:38am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 10:38am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 10:38am

Copy link

changeset-bot bot commented Feb 25, 2025

⚠️ No Changeset found

Latest commit: 56301bc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joaquim-verges joaquim-verges marked this pull request as ready for review February 25, 2025 11:44
@joaquim-verges joaquim-verges requested review from a team as code owners February 25, 2025 11:44
@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Feb 25, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

socket-security bot commented Feb 25, 2025

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/[email protected]

View full report↗︎

Have feedback? Participate in our User Experience Survey 📊

Copy link
Contributor

github-actions bot commented Feb 25, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.87 KB (+0.27% 🔺) 938 ms (+0.27% 🔺) 142 ms (+124.75% 🔺) 1.1 s
thirdweb (cjs) 127.15 KB (+2.04% 🔺) 2.6 s (+2.04% 🔺) 229 ms (+50.69% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 59 ms (+1221.03% 🔺) 171 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 29 ms (+1186.87% 🔺) 39 ms
thirdweb/react (minimal + tree-shaking) 19.38 KB (+0.19% 🔺) 388 ms (+0.19% 🔺) 64 ms (+369.86% 🔺) 452 ms

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.60%. Comparing base (36b4ea5) to head (56301bc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6336      +/-   ##
==========================================
- Coverage   54.61%   54.60%   -0.01%     
==========================================
  Files         874      874              
  Lines       54525    54525              
  Branches     3680     3682       +2     
==========================================
- Hits        29777    29774       -3     
- Misses      24653    24656       +3     
  Partials       95       95              
Flag Coverage Δ
packages 54.60% <ø> (-0.01%) ⬇️

see 3 files with indirect coverage changes

Copy link

graphite-app bot commented Feb 28, 2025

Merge activity

<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates several dependencies, particularly the `viem` package, and makes adjustments to the `package.json` and lock files to reflect these changes. It also increases the size limit in the `.size-limit.json` file.

### Detailed summary
- Updated `viem` version from `2.22.17` to `2.23.5` in `package.json` and `pnpm-lock.yaml`.
- Increased size limit in `packages/thirdweb/.size-limit.json` from `130 kB` to `131 kB`.
- Adjusted various dependencies in `pnpm-lock.yaml` to include `@swc/[email protected]`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants