[TOOL-3525] Dashboard: Add delete account in account settings page #6339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
MananTank
changed the title
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
MananTank
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6339 +/- ##
=======================================
Coverage 54.60% 54.60%
=======================================
Files 874 874
Lines 54525 54525
Branches 3680 3680
=======================================
Hits 29772 29772
Misses 24658 24658
Partials 95 95
|
MananTank
changed the title
jnsdls
approved these changes
Feb 28, 2025
Merge activity
|
…6339) <!-- ## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes" If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000): ## Notes for the reviewer Anything important to call out? Be sure to also clarify these in your comments. ## How to test Unit tests, playground, etc. --> <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on enhancing the management of teams and accounts in the application. It introduces a new method to fetch the default team and updates various components to utilize this information, improving user experience and functionality. ### Detailed summary - Added `getDefaultTeam` function to fetch the default team using an API call. - Updated `TeamRootPage` to use `getDefaultTeam` instead of fetching all teams. - Modified middleware to redirect using the default team. - Refactored account settings page to include `defaultTeamSlug` and `defaultTeamName`. - Enhanced `DangerSettingCard` to manage confirmation dialog state. - Updated `AccountSettingsPageUI` to handle account deletion with relevant alerts for errors. - Added UI components for handling account deletion status responses in the storybook. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
graphite-app
bot
force-pushed
the
tool-3525
branch
from
1c9bcc9 to
853ed47
Compare
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR-Codex overview
This PR focuses on refactoring the team retrieval logic in the
TeamRootPageand middleware to use thegetDefaultTeamfunction. It also enhances the account settings page by integrating default team information and updating the delete account functionality to handle various states.Detailed summary
TeamRootPagewithgetDefaultTeam().getDefaultTeam().AccountSettingsPageto includedefaultTeamSluganddefaultTeamName.DangerSettingCardto manage confirmation dialog state.AccountSettingsPageUIto pass default team info and handle account deletion.DeleteAccountCard.