Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monad-faucet-starter+-only #6351

Merged
merged 1 commit into from
Feb 26, 2025
Merged

monad-faucet-starter+-only #6351

merged 1 commit into from
Feb 26, 2025

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Feb 26, 2025

PR-Codex overview

This PR introduces a new response type for the faucet claiming feature, specifically handling cases where a user cannot claim due to unsupported chains or requiring a paid plan. It also adds checks for user account plans and refines the error handling for account verification.

Detailed summary

  • Added a new CanClaimResponseType for "paid-plan-required" status.
  • Updated FaucetButton to display a message for "paid-plan-required".
  • Enhanced the GET route to return "paid-plan-required" if no teams are found or if the user has no paid plan.
  • Refined error handling in the POST route for account verification and team checks.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Feb 26, 2025

⚠️ No Changeset found

Latest commit: 480da2e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – login February 26, 2025 15:57 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 26, 2025 15:57 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 26, 2025 15:57 Inactive
Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 4:41pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 26, 2025 4:41pm
login ⬜️ Skipped (Inspect) Feb 26, 2025 4:41pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 26, 2025 4:41pm
wallet-ui ⬜️ Skipped (Inspect) Feb 26, 2025 4:41pm

@vercel vercel bot temporarily deployed to Preview – docs-v2 February 26, 2025 15:57 Inactive
@jnsdls jnsdls marked this pull request as ready for review February 26, 2025 15:57
@jnsdls jnsdls requested review from a team as code owners February 26, 2025 15:57
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 26, 2025
Copy link
Contributor

github-actions bot commented Feb 26, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.56 KB (0%) 932 ms (0%) 391 ms (+20.63% 🔺) 1.4 s
thirdweb (cjs) 124.25 KB (0%) 2.5 s (0%) 644 ms (-17.32% 🔽) 3.2 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 74 ms (+74.09% 🔺) 186 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 29 ms (+456.35% 🔺) 39 ms
thirdweb/react (minimal + tree-shaking) 19.35 KB (0%) 387 ms (0%) 166 ms (+160.33% 🔺) 553 ms

@jnsdls jnsdls force-pushed the 02-26-monad-faucet-growth_-only branch from 1325058 to e6687d5 Compare February 26, 2025 16:06
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 26, 2025 16:06 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 26, 2025 16:06 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 26, 2025 16:06 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 26, 2025 16:06 Inactive
Copy link
Member Author

jnsdls commented Feb 26, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls changed the title monad-faucet-growth+-only monad-faucet-starter+-only Feb 26, 2025
@jnsdls jnsdls force-pushed the 02-26-monad-faucet-growth_-only branch from e6687d5 to b153b28 Compare February 26, 2025 16:19
@vercel vercel bot temporarily deployed to Preview – login February 26, 2025 16:19 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 26, 2025 16:19 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 26, 2025 16:19 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 26, 2025 16:19 Inactive
@jnsdls jnsdls force-pushed the 02-26-monad-faucet-growth_-only branch from b153b28 to 18fd199 Compare February 26, 2025 16:27
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 26, 2025 16:27 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 26, 2025 16:27 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 26, 2025 16:27 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 26, 2025 16:27 Inactive
@jnsdls jnsdls force-pushed the 02-26-monad-faucet-growth_-only branch from 18fd199 to 50540de Compare February 26, 2025 16:29
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 26, 2025 16:29 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 26, 2025 16:29 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 26, 2025 16:29 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 26, 2025 16:29 Inactive
@jnsdls jnsdls force-pushed the 02-26-monad-faucet-growth_-only branch from 50540de to 480da2e Compare February 26, 2025 16:29
@vercel vercel bot temporarily deployed to Preview – login February 26, 2025 16:29 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 26, 2025 16:29 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 26, 2025 16:29 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 26, 2025 16:29 Inactive
@jnsdls jnsdls merged commit 0df4275 into main Feb 26, 2025
29 of 31 checks passed
@jnsdls jnsdls deleted the 02-26-monad-faucet-growth_-only branch February 26, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant