Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tutorial/guide slug routes to framer rewrites #6364

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Feb 27, 2025

Added support for dynamic routing of individual tutorial and guide pages in the learn section by including :tutorial_slug and :guide_slug path parameters.

Copy link

vercel bot commented Feb 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 27, 2025 6:51pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 27, 2025 6:51pm
login ⬜️ Skipped (Inspect) Feb 27, 2025 6:51pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 27, 2025 6:51pm
wallet-ui ⬜️ Skipped (Inspect) Feb 27, 2025 6:51pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui February 27, 2025 18:45 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 27, 2025 18:45 Inactive
@vercel vercel bot temporarily deployed to Preview – login February 27, 2025 18:45 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 27, 2025 18:45 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 27, 2025
@jnsdls jnsdls marked this pull request as ready for review February 27, 2025 18:45
@jnsdls jnsdls requested review from a team as code owners February 27, 2025 18:45
Copy link
Member Author

jnsdls commented Feb 27, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls merged commit 28392b4 into main Feb 27, 2025
29 of 36 checks passed
@jnsdls jnsdls deleted the add_tutorial/guide_slug_routes_to_framer_rewrites branch February 27, 2025 18:45
Copy link
Contributor

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.64 KB (0%) 933 ms (0%) 142 ms (+134.97% 🔺) 1.1 s
thirdweb (cjs) 124.56 KB (0%) 2.5 s (0%) 212 ms (+30.75% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 66 ms (+865.63% 🔺) 178 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 14 ms (+615.68% 🔺) 24 ms
thirdweb/react (minimal + tree-shaking) 19.35 KB (0%) 387 ms (0%) 52 ms (+320.29% 🔺) 439 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant