Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOOL-3569] Dashboard: Add acount.id to posthog identify calls #6377

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Feb 28, 2025

PR-Codex overview

This PR introduces a new server-side component PosthogIdentifierServer that retrieves account information and uses it to render the PosthogIdentifierClient. It replaces the previous PosthogIdentifier component in the app layout, enhancing how user identification is handled.

Detailed summary

  • Added PosthogIdentifierServer in PosthogIdentifierServer.tsx to fetch account data.
  • Replaced the PosthogIdentifier component with PosthogIdentifierServer in layout.tsx.
  • Modified PosthogIdentifier to PosthogIdentifierClient, accepting accountId and accountAddress as props.
  • Updated identification logic in PosthogIdentifierClient to use accountId and accountAddress.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Feb 28, 2025

Copy link

vercel bot commented Feb 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 9:21pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Feb 28, 2025 9:21pm
login ⬜️ Skipped (Inspect) Feb 28, 2025 9:21pm
thirdweb_playground ⬜️ Skipped (Inspect) Feb 28, 2025 9:21pm
wallet-ui ⬜️ Skipped (Inspect) Feb 28, 2025 9:21pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui February 28, 2025 20:42 Inactive
Copy link

changeset-bot bot commented Feb 28, 2025

⚠️ No Changeset found

Latest commit: 062504f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – login February 28, 2025 20:42 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 28, 2025 20:42 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 28, 2025 20:42 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Feb 28, 2025
@MananTank MananTank marked this pull request as ready for review February 28, 2025 20:42
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank requested review from a team as code owners February 28, 2025 20:42
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.60%. Comparing base (853ed47) to head (062504f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6377   +/-   ##
=======================================
  Coverage   54.60%   54.60%           
=======================================
  Files         874      874           
  Lines       54525    54525           
  Branches     3680     3680           
=======================================
  Hits        29772    29772           
  Misses      24658    24658           
  Partials       95       95           
Flag Coverage Δ
packages 54.60% <ø> (ø)

Copy link
Contributor

github-actions bot commented Feb 28, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.87 KB (0%) 938 ms (0%) 143 ms (+135.54% 🔺) 1.1 s
thirdweb (cjs) 127.15 KB (0%) 2.6 s (0%) 216 ms (+33% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 71 ms (+1377.5% 🔺) 183 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 25 ms (+1371.84% 🔺) 35 ms
thirdweb/react (minimal + tree-shaking) 19.38 KB (0%) 388 ms (0%) 72 ms (+481% 🔺) 460 ms

Copy link

graphite-app bot commented Feb 28, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 03-01-_tool-3569_dashboard_add_acount.id_to_posthog_identify_calls branch from 140149f to 062504f Compare February 28, 2025 21:14
@vercel vercel bot temporarily deployed to Preview – login February 28, 2025 21:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground February 28, 2025 21:14 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 February 28, 2025 21:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui February 28, 2025 21:14 Inactive
@graphite-app graphite-app bot merged commit 062504f into main Feb 28, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 03-01-_tool-3569_dashboard_add_acount.id_to_posthog_identify_calls branch February 28, 2025 21:21
@vercel vercel bot temporarily deployed to Production – login February 28, 2025 21:21 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 February 28, 2025 21:21 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground February 28, 2025 21:21 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants