Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOOL-3571] Dashboard: Remove custom high z-indices #6380

Merged
merged 1 commit into from
Mar 1, 2025
Merged

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Mar 1, 2025

PR-Codex overview

This PR focuses on removing excessive z-index classes from various DialogContent and SheetContent components across multiple files, streamlining the styling for better maintainability.

Detailed summary

  • Removed className="z-[10001]" from DialogContent in multiple files.
  • Removed className="z-[10000]" from DialogOverlayClassName in multiple files.
  • Removed className="z-[10000]" from SheetContent in multiple files.
  • Simplified className attributes in PopoverContent and SelectContent.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Mar 1, 2025

Copy link

vercel bot commented Mar 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2025 0:18am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 1, 2025 0:18am
login ⬜️ Skipped (Inspect) Mar 1, 2025 0:18am
thirdweb_playground ⬜️ Skipped (Inspect) Mar 1, 2025 0:18am
wallet-ui ⬜️ Skipped (Inspect) Mar 1, 2025 0:18am

@vercel vercel bot temporarily deployed to Preview – login March 1, 2025 00:00 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 1, 2025 00:00 Inactive
Copy link

changeset-bot bot commented Mar 1, 2025

⚠️ No Changeset found

Latest commit: b535cc8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – wallet-ui March 1, 2025 00:00 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 1, 2025 00:00 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 1, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review March 1, 2025 00:00
@MananTank MananTank requested review from a team as code owners March 1, 2025 00:00
@MananTank MananTank added the hotfix This pull request should be prioritized in the merge queue. label Mar 1, 2025 — with Graphite App
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.71%. Comparing base (c3ded8a) to head (b535cc8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6380   +/-   ##
=======================================
  Coverage   54.71%   54.71%           
=======================================
  Files         874      874           
  Lines       54617    54617           
  Branches     3717     3717           
=======================================
  Hits        29885    29885           
  Misses      24637    24637           
  Partials       95       95           
Flag Coverage Δ
packages 54.71% <ø> (ø)

Copy link
Contributor

github-actions bot commented Mar 1, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.82 KB (0%) 937 ms (0%) 137 ms (+134.09% 🔺) 1.1 s
thirdweb (cjs) 127.18 KB (0%) 2.6 s (0%) 195 ms (+26.13% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 55 ms (+1226.39% 🔺) 167 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 16 ms (+783.4% 🔺) 26 ms
thirdweb/react (minimal + tree-shaking) 19.38 KB (0%) 388 ms (0%) 49 ms (+296.82% 🔺) 436 ms

Copy link

graphite-app bot commented Mar 1, 2025

Merge activity

@vercel vercel bot temporarily deployed to Preview – wallet-ui March 1, 2025 00:11 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 1, 2025 00:11 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 1, 2025 00:11 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 1, 2025 00:11 Inactive
@graphite-app graphite-app bot merged commit b535cc8 into main Mar 1, 2025
32 checks passed
@graphite-app graphite-app bot deleted the tool-3571 branch March 1, 2025 00:18
@vercel vercel bot temporarily deployed to Production – login March 1, 2025 00:18 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui March 1, 2025 00:18 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. hotfix This pull request should be prioritized in the merge queue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants