Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[service-utils] trim project ID prefix #6382

Merged
merged 1 commit into from
Mar 1, 2025
Merged

Conversation

arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Mar 1, 2025

PR-Codex overview

This PR focuses on updating the UsageV2Producer class in the service-utils package to trim specific prefixes from team_id and project_id fields.

Detailed summary

  • Added constants TEAM_ID_PREFIX and PROJECT_ID_PREFIX for prefix management.
  • Modified team_id to remove the team_ prefix using the new constant.
  • Added logic to remove the prj_ prefix from project_id if present.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested a review from a team as a code owner March 1, 2025 02:53
Copy link

vercel bot commented Mar 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2025 2:59am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2025 2:59am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2025 2:59am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2025 2:59am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2025 2:59am

Copy link

changeset-bot bot commented Mar 1, 2025

🦋 Changeset detected

Latest commit: acf883f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@thirdweb-dev/service-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

graphite-app bot commented Mar 1, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@arcoraven arcoraven merged commit 47c9c43 into main Mar 1, 2025
8 of 13 checks passed
@arcoraven arcoraven deleted the ph/trim-project-id-prefix branch March 1, 2025 02:53
@joaquim-verges joaquim-verges mentioned this pull request Mar 1, 2025
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.53%. Comparing base (f693ab8) to head (acf883f).
Report is 58 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6382      +/-   ##
==========================================
- Coverage   56.83%   56.53%   -0.30%     
==========================================
  Files        1168     1170       +2     
  Lines       64793    65496     +703     
  Branches     5258     5310      +52     
==========================================
+ Hits        36824    37031     +207     
- Misses      27242    27737     +495     
- Partials      727      728       +1     
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from f693ab8
packages 54.71% <ø> (-0.33%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

see 20 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Mar 1, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.82 KB (0%) 937 ms (0%) 225 ms (+300.8% 🔺) 1.2 s
thirdweb (cjs) 127.18 KB (0%) 2.6 s (0%) 296 ms (+93.76% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 82 ms (+1241.9% 🔺) 194 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 27 ms (+1750.24% 🔺) 37 ms
thirdweb/react (minimal + tree-shaking) 19.38 KB (0%) 388 ms (0%) 99 ms (+573.73% 🔺) 487 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant