Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: relative path import for usageV2 #6385

Merged
merged 1 commit into from
Mar 1, 2025

Conversation

arcoraven
Copy link
Contributor

@arcoraven arcoraven commented Mar 1, 2025

PR-Codex overview

This PR focuses on updating the import path for CoreAuthInput in the usageV2.ts file to use a relative path instead of an absolute path.

Detailed summary

  • Changed the import path for CoreAuthInput from "src/core/types.js" to "../core/types.js" in packages/service-utils/src/cf-worker/usageV2.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@arcoraven arcoraven requested a review from a team as a code owner March 1, 2025 05:47
Copy link

vercel bot commented Mar 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 1, 2025 5:54am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 1, 2025 5:54am
login ⬜️ Skipped (Inspect) Mar 1, 2025 5:54am
thirdweb_playground ⬜️ Skipped (Inspect) Mar 1, 2025 5:54am
wallet-ui ⬜️ Skipped (Inspect) Mar 1, 2025 5:54am

@vercel vercel bot temporarily deployed to Preview – login March 1, 2025 05:47 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 1, 2025 05:47 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 1, 2025 05:47 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 1, 2025 05:47 Inactive
Copy link

changeset-bot bot commented Mar 1, 2025

⚠️ No Changeset found

Latest commit: 6d39bcb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Mar 1, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@arcoraven arcoraven merged commit 879148f into main Mar 1, 2025
12 of 13 checks passed
@arcoraven arcoraven deleted the ph/fix-import-relative-path-2025-03-01 branch March 1, 2025 05:47
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.71%. Comparing base (25b149d) to head (6d39bcb).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6385   +/-   ##
=======================================
  Coverage   54.71%   54.71%           
=======================================
  Files         874      874           
  Lines       54617    54617           
  Branches     3717     3717           
=======================================
  Hits        29885    29885           
  Misses      24637    24637           
  Partials       95       95           
Flag Coverage Δ
packages 54.71% <ø> (ø)

Copy link
Contributor

github-actions bot commented Mar 1, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.82 KB (0%) 937 ms (0%) 171 ms (+182.28% 🔺) 1.2 s
thirdweb (cjs) 127.18 KB (0%) 2.6 s (0%) 255 ms (+64.59% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 88 ms (+863.58% 🔺) 200 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 33 ms (+1910.88% 🔺) 43 ms
thirdweb/react (minimal + tree-shaking) 19.38 KB (0%) 388 ms (0%) 83 ms (+758.89% 🔺) 470 ms

Copy link
Member

@jnsdls jnsdls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jnsdls approved this PR from Slack with Graphite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants