-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] fix: Handle comma decimal input in PayEmbed #6386
[SDK] fix: Handle comma decimal input in PayEmbed #6386
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 6f11f25 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
@@ -654,6 +654,9 @@ function SelectedTokenInfo(props: { | |||
onChange={(e) => { | |||
let value = e.target.value; | |||
|
|||
// Replace comma with period if it exists | |||
value = value.replace(",", "."); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider using replaceAll()
instead of replace()
since the input may contain multiple commas that need to be converted to decimal points. Example: "1,234,56" -> "1.234.56"
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
size-limit report 📦
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6386 +/- ##
=======================================
Coverage 54.71% 54.72%
=======================================
Files 874 874
Lines 54617 54619 +2
Branches 3717 3718 +1
=======================================
+ Hits 29885 29890 +5
+ Misses 24637 24634 -3
Partials 95 95
|
Fixes #6337