Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOOL-3581] Dashboard: Fix project overview page crashing because of ContractDistributionCard #6392

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Mar 3, 2025

PR-Codex overview

This PR refactors the TransactionCharts.tsx file by renaming the variable reducedData to _reducedData, adding error handling for asynchronous operations, and filtering out undefined values from the final result.

Detailed summary

  • Renamed variable reducedData to _reducedData.
  • Introduced a try-catch block for error handling during async operations.
  • Added a check to skip processing if chainId is 0.
  • Filtered _reducedData to exclude undefined entries before assignment to reducedData.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Mar 3, 2025

Copy link

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 6:46pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 3, 2025 6:46pm
login ⬜️ Skipped (Inspect) Mar 3, 2025 6:46pm
thirdweb_playground ⬜️ Skipped (Inspect) Mar 3, 2025 6:46pm
wallet-ui ⬜️ Skipped (Inspect) Mar 3, 2025 6:46pm

Copy link

changeset-bot bot commented Mar 3, 2025

⚠️ No Changeset found

Latest commit: 0046018

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – login March 3, 2025 18:32 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 3, 2025 18:32 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 3, 2025 18:32 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 3, 2025 18:32 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 3, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@MananTank MananTank marked this pull request as ready for review March 3, 2025 18:33
@MananTank MananTank requested review from a team as code owners March 3, 2025 18:33
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.70%. Comparing base (cbc0eff) to head (0046018).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6392   +/-   ##
=======================================
  Coverage   54.70%   54.70%           
=======================================
  Files         874      874           
  Lines       54620    54620           
  Branches     3729     3729           
=======================================
  Hits        29881    29881           
  Misses      24646    24646           
  Partials       93       93           
Flag Coverage Δ
packages 54.70% <ø> (ø)

Copy link
Contributor

github-actions bot commented Mar 3, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.85 KB (0%) 937 ms (0%) 150 ms (+104.32% 🔺) 1.1 s
thirdweb (cjs) 127.21 KB (0%) 2.6 s (0%) 226 ms (+37.58% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 68 ms (+997.72% 🔺) 180 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 31 ms (+1989.15% 🔺) 41 ms
thirdweb/react (minimal + tree-shaking) 19.38 KB (0%) 388 ms (0%) 68 ms (+450.06% 🔺) 455 ms

Copy link

graphite-app bot commented Mar 3, 2025

Merge activity

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 3, 2025 18:39 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 3, 2025 18:39 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 3, 2025 18:39 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 3, 2025 18:39 Inactive
@graphite-app graphite-app bot merged commit 0046018 into main Mar 3, 2025
32 checks passed
@graphite-app graphite-app bot deleted the tool-3581 branch March 3, 2025 18:47
@vercel vercel bot temporarily deployed to Production – wallet-ui March 3, 2025 18:47 Inactive
@vercel vercel bot temporarily deployed to Production – login March 3, 2025 18:47 Inactive
@vercel vercel bot temporarily deployed to Production – docs-v2 March 3, 2025 18:47 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants