Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TOOL-3584] Dashboad: Move turnstile widget above connect embed in login page #6394

Conversation

MananTank
Copy link
Member

@MananTank MananTank commented Mar 3, 2025

PR-Codex overview

This PR focuses on updating the LoginPage.tsx component by modifying the usage of the Turnstile component. It adds a new instance of Turnstile while removing the previous one, ensuring that it only appears when interaction is required.

Detailed summary

  • Added a new Turnstile component with specific options and siteKey.
  • Set the onSuccess handler for the Turnstile to update the turnstileToken.
  • Removed the old Turnstile component from the return statement.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

linear bot commented Mar 3, 2025

Copy link

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 8:28pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 3, 2025 8:28pm
login ⬜️ Skipped (Inspect) Mar 3, 2025 8:28pm
thirdweb_playground ⬜️ Skipped (Inspect) Mar 3, 2025 8:28pm
wallet-ui ⬜️ Skipped (Inspect) Mar 3, 2025 8:28pm

Copy link

changeset-bot bot commented Mar 3, 2025

⚠️ No Changeset found

Latest commit: 0d82fc0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – login March 3, 2025 20:14 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 3, 2025 20:14 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 3, 2025 20:14 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 3, 2025 20:14 Inactive
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 3, 2025
@MananTank MananTank marked this pull request as ready for review March 3, 2025 20:15
@MananTank MananTank requested review from a team as code owners March 3, 2025 20:15
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.70%. Comparing base (ef6029b) to head (0d82fc0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6394   +/-   ##
=======================================
  Coverage   54.70%   54.70%           
=======================================
  Files         874      874           
  Lines       54620    54620           
  Branches     3729     3729           
=======================================
  Hits        29881    29881           
  Misses      24646    24646           
  Partials       93       93           
Flag Coverage Δ
packages 54.70% <ø> (ø)

Copy link
Contributor

github-actions bot commented Mar 3, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.85 KB (0%) 937 ms (0%) 197 ms (+125.33% 🔺) 1.2 s
thirdweb (cjs) 127.21 KB (0%) 2.6 s (0%) 305 ms (+22.68% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 81 ms (+1080.24% 🔺) 193 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 29 ms (+1376.29% 🔺) 39 ms
thirdweb/react (minimal + tree-shaking) 19.38 KB (0%) 388 ms (0%) 82 ms (+202.79% 🔺) 470 ms

Copy link

graphite-app bot commented Mar 3, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 03-04-_tool-3584_dashboad_move_turnstile_widget_above_connect_embed_in_login_page branch from 21f4348 to 0d82fc0 Compare March 3, 2025 20:22
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 3, 2025 20:22 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 3, 2025 20:22 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 3, 2025 20:22 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 3, 2025 20:22 Inactive
@graphite-app graphite-app bot merged commit 0d82fc0 into main Mar 3, 2025
32 checks passed
@graphite-app graphite-app bot deleted the 03-04-_tool-3584_dashboad_move_turnstile_widget_above_connect_embed_in_login_page branch March 3, 2025 20:29
@vercel vercel bot temporarily deployed to Production – login March 3, 2025 20:29 Inactive
@vercel vercel bot temporarily deployed to Production – wallet-ui March 3, 2025 20:29 Inactive
@vercel vercel bot temporarily deployed to Production – thirdweb_playground March 3, 2025 20:29 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants