Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove secretHash from rotate key response #6401

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Mar 3, 2025

No description provided.

Copy link

changeset-bot bot commented Mar 3, 2025

⚠️ No Changeset found

Latest commit: a42529b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 9:40pm
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 9:40pm
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 9:40pm
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 9:40pm
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 9:40pm

@github-actions github-actions bot added Dashboard Involves changes to the Dashboard. packages labels Mar 3, 2025
@jnsdls jnsdls marked this pull request as ready for review March 3, 2025 21:32
@github-actions github-actions bot added the SDK Involves changes to the thirdweb SDK label Mar 3, 2025
@jnsdls jnsdls requested review from a team as code owners March 3, 2025 21:32
Copy link
Member Author

jnsdls commented Mar 3, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls merged commit 33ddf56 into main Mar 3, 2025
25 of 30 checks passed
@jnsdls jnsdls deleted the remove_secretHash_from_rotate_key_response branch March 3, 2025 21:32
Copy link
Contributor

github-actions bot commented Mar 3, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.85 KB (0%) 937 ms (0%) 193 ms (+120.54% 🔺) 1.2 s
thirdweb (cjs) 127.21 KB (0%) 2.6 s (0%) 301 ms (+25.86% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 88 ms (+1159.98% 🔺) 200 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 39 ms (+1679.82% 🔺) 49 ms
thirdweb/react (minimal + tree-shaking) 19.38 KB (0%) 388 ms (0%) 108 ms (+342.97% 🔺) 496 ms

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.72%. Comparing base (f4ca73c) to head (a42529b).
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6401      +/-   ##
==========================================
+ Coverage   54.60%   54.72%   +0.12%     
==========================================
  Files         874      874              
  Lines       54525    54620      +95     
  Branches     3680     3720      +40     
==========================================
+ Hits        29772    29893     +121     
+ Misses      24658    24632      -26     
  Partials       95       95              
Flag Coverage Δ
packages 54.72% <ø> (+0.12%) ⬆️

see 9 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant