Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update implementations #6405

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Update implementations #6405

merged 1 commit into from
Mar 4, 2025

Conversation

kumaryash90
Copy link
Member

@kumaryash90 kumaryash90 commented Mar 3, 2025


PR-Codex overview

This PR updates the MarketplaceV3 addresses in the ZKSYNC_IMPLEMENTATIONS constant to reflect new deployment addresses.

Detailed summary

  • Updated MarketplaceV3 address at index [324] from 0xBc02441a36Bb4029Cd191b20243c2e41B862F118 to 0x88e7F2bEf0a23073b7Cc2c79D307Dbd9138Fa79c.
  • Updated MarketplaceV3 address at index [2741] from 0x4027561E163a420c4e5Db46E07EBd581CAa8Bb62 to 0x4b14569c7B79DBe686Ac3Ba5996131E7EDaB7a93.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@kumaryash90 kumaryash90 requested review from a team as code owners March 3, 2025 22:00
Copy link

changeset-bot bot commented Mar 3, 2025

⚠️ No Changeset found

Latest commit: cb71dd5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 0:10am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 0:10am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 0:10am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 0:10am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 0:10am

Copy link

graphite-app bot commented Mar 3, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 3, 2025
Copy link
Contributor

github-actions bot commented Mar 3, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.85 KB (0%) 937 ms (0%) 156 ms (+428.38% 🔺) 1.1 s
thirdweb (cjs) 127.21 KB (0%) 2.6 s (0%) 178 ms (+109.28% 🔺) 2.8 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 71 ms (+2096.08% 🔺) 183 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 16 ms (+2010.18% 🔺) 26 ms
thirdweb/react (minimal + tree-shaking) 19.38 KB (0%) 388 ms (0%) 39 ms (+366.28% 🔺) 427 ms

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.73%. Comparing base (83ec695) to head (cb71dd5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6405      +/-   ##
==========================================
+ Coverage   54.71%   54.73%   +0.02%     
==========================================
  Files         874      874              
  Lines       54620    54620              
  Branches     3718     3722       +4     
==========================================
+ Hits        29884    29895      +11     
+ Misses      24641    24630      -11     
  Partials       95       95              
Flag Coverage Δ
packages 54.73% <100.00%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
.../src/contract/deployment/zksync/implementations.ts 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 3, 2025 23:55 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 3, 2025 23:55 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 3, 2025 23:55 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 3, 2025 23:55 Inactive
@kumaryash90 kumaryash90 added the merge-queue Adds the pull request to Graphite's merge queue. label Mar 3, 2025
Copy link
Member Author

kumaryash90 commented Mar 3, 2025

Merge activity

  • Mar 3, 6:55 PM EST: The merge label 'merge-queue' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Mar 3, 7:03 PM EST: A user added this pull request to the Graphite merge queue.
  • Mar 3, 7:10 PM EST: A user merged this pull request with the Graphite merge queue.

@vercel vercel bot temporarily deployed to Preview – login March 4, 2025 00:00 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 4, 2025 00:00 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 4, 2025 00:00 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb-www March 4, 2025 00:00 Inactive
<!--

## title your PR with this format: "[SDK/Dashboard/Portal] Feature/Fix: Concise title for the changes"

If you did not copy the branch name from Linear, paste the issue tag here (format is TEAM-0000):

## Notes for the reviewer

Anything important to call out? Be sure to also clarify these in your comments.

## How to test

Unit tests, playground, etc.

-->

<!-- start pr-codex -->

---

## PR-Codex overview
This PR updates the `MarketplaceV3` addresses in the `ZKSYNC_IMPLEMENTATIONS` object for various entries to new contract addresses.

### Detailed summary
- Updated `MarketplaceV3` address from `0xBc02441a36Bb4029Cd191b20243c2e41B862F118` to `0x88e7F2bEf0a23073b7Cc2c79D307Dbd9138Fa79c` at index `324`.
- Updated `MarketplaceV3` address from `0x4027561E163a420c4e5Db46E07EBd581CAa8Bb62` to `0x4b14569c7B79DBe686Ac3Ba5996131E7EDaB7a93` at index `2741`.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-queue Adds the pull request to Graphite's merge queue. packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants