Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update engine API routes to include team slug #6407

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jnsdls
Copy link
Member

@jnsdls jnsdls commented Mar 4, 2025

blocked by: https://app.graphite.dev/github/pr/thirdweb-dev/api-server/1437/add-team-engine-management-endpoints


PR-Codex overview

This PR focuses on enhancing the handling of teamIdOrSlug across various components and API interactions in the application. It ensures that the teamIdOrSlug is consistently passed and used where necessary, improving the overall functionality and organization of the code.

Detailed summary

  • Added teamIdOrSlug parameter to multiple functions and components.
  • Updated API endpoints to include teamIdOrSlug for fetching engine instances and alerts.
  • Modified components to pass teamIdOrSlug to child components (e.g., EngineAlertsPage, EngineSystem).
  • Adjusted data handling to accommodate changes in API responses (e.g., result instead of data).
  • Enhanced useEngineAlerts, useEngineAlertRules, and other hooks to support teamIdOrSlug.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Mar 4, 2025

⚠️ No Changeset found

Latest commit: 4aacef1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 8:27am
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Mar 4, 2025 8:27am
login ⬜️ Skipped (Inspect) Mar 4, 2025 8:27am
thirdweb_playground ⬜️ Skipped (Inspect) Mar 4, 2025 8:27am
wallet-ui ⬜️ Skipped (Inspect) Mar 4, 2025 8:27am

@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 4, 2025 07:56 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 4, 2025 07:56 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 4, 2025 07:56 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 4, 2025 07:56 Inactive
@jnsdls jnsdls added the DO NOT MERGE This pull request is still in progress and is not ready to be merged. label Mar 4, 2025 — with Graphite App
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Mar 4, 2025
@jnsdls jnsdls marked this pull request as ready for review March 4, 2025 07:56
@jnsdls jnsdls requested review from a team as code owners March 4, 2025 07:56
Copy link
Member Author

jnsdls commented Mar 4, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jnsdls jnsdls force-pushed the update_engine_API_routes_to_include_team_slug branch from 9f15926 to 2d8fde0 Compare March 4, 2025 07:57
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 4, 2025 07:57 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 4, 2025 07:57 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 4, 2025 07:57 Inactive
@vercel vercel bot temporarily deployed to Preview – login March 4, 2025 07:57 Inactive
Copy link
Contributor

github-actions bot commented Mar 4, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.82 KB (0%) 937 ms (0%) 191 ms (+122.81% 🔺) 1.2 s
thirdweb (cjs) 127.36 KB (0%) 2.6 s (0%) 309 ms (+23.22% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 70 ms (+549.49% 🔺) 182 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 42 ms (+1755.31% 🔺) 52 ms
thirdweb/react (minimal + tree-shaking) 19.33 KB (0%) 387 ms (0%) 100 ms (+470.86% 🔺) 487 ms

@jnsdls jnsdls force-pushed the update_engine_API_routes_to_include_team_slug branch from 2d8fde0 to 4aacef1 Compare March 4, 2025 08:20
@vercel vercel bot temporarily deployed to Preview – login March 4, 2025 08:20 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground March 4, 2025 08:20 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 March 4, 2025 08:20 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-ui March 4, 2025 08:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. DO NOT MERGE This pull request is still in progress and is not ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants