Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] feat: update zksync chain checks #6408

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 4, 2025


PR-Codex overview

This PR updates the isZkSyncChain function to modify the conditions for identifying specific chain.id values.

Detailed summary

  • Removed the condition chain.id === 61166.
  • Added the condition chain.id === 555272.
  • The overall logic now includes chain.id values of 240, 555271, 61166, and 555272 to return true.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

changeset-bot bot commented Mar 4, 2025

⚠️ No Changeset found

Latest commit: bf33c6b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 8:08am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 8:08am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 8:08am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 8:08am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 4, 2025 8:08am

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 4, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joaquim-verges joaquim-verges changed the title [SDK] feat: Add zkSync chain ID 555272 [SDK] feat: update zksync chain checks Mar 4, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review March 4, 2025 08:00
@joaquim-verges joaquim-verges requested review from a team as code owners March 4, 2025 08:00
Copy link
Contributor

github-actions bot commented Mar 4, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.76 KB (-0.13% 🔽) 936 ms (-0.13% 🔽) 183 ms (+133.57% 🔺) 1.2 s
thirdweb (cjs) 127.15 KB (-0.16% 🔽) 2.6 s (-0.16% 🔽) 292 ms (+8.7% 🔺) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 91 ms (+959.06% 🔺) 202 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 36 ms (+745.22% 🔺) 46 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (+0.04% 🔺) 387 ms (+0.04% 🔺) 88 ms (+392.48% 🔺) 475 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant