Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] fix: Allow resending OTP on failures #6412

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

joaquim-verges
Copy link
Member

@joaquim-verges joaquim-verges commented Mar 4, 2025


PR-Codex overview

This PR focuses on enhancing the OTP resend functionality and refining transaction error handling in the thirdweb package. It also updates test cases to improve clarity and accuracy.

Detailed summary

  • Added functionality to allow resending OTP on failures.
  • Updated error message in smart-wallet-integration-v07.test.ts for unauthorized transactions.
  • Modified OTPLoginUI.tsx to show resend button when not sending.
  • Improved assertions in gasless transaction tests for clarity.
  • Removed redundant test case in drop1155.test.ts.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-v2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 0:08am
login ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 0:08am
thirdweb_playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 0:08am
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 0:08am
wallet-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2025 0:08am

Copy link

changeset-bot bot commented Mar 4, 2025

🦋 Changeset detected

Latest commit: 9ab7061

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
thirdweb Patch
@thirdweb-dev/wagmi-adapter Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added packages SDK Involves changes to the thirdweb SDK labels Mar 4, 2025
@joaquim-verges joaquim-verges marked this pull request as ready for review March 4, 2025 20:34
@joaquim-verges joaquim-verges requested review from a team as code owners March 4, 2025 20:34
Copy link
Member Author

joaquim-verges commented Mar 4, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge-queue - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor

github-actions bot commented Mar 4, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 46.76 KB (0%) 936 ms (0%) 177 ms (+56.11% 🔺) 1.2 s
thirdweb (cjs) 127.15 KB (0%) 2.6 s (0%) 304 ms (-8.25% 🔽) 2.9 s
thirdweb (minimal + tree-shaking) 5.6 KB (0%) 112 ms (0%) 31 ms (+136.69% 🔺) 143 ms
thirdweb/chains (tree-shaking) 506 B (0%) 10 ms (0%) 19 ms (+408.64% 🔺) 29 ms
thirdweb/react (minimal + tree-shaking) 19.34 KB (0%) 387 ms (0%) 54 ms (+94.8% 🔺) 441 ms

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 54.72%. Comparing base (b5e02a4) to head (9ab7061).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...irdweb/src/react/web/wallets/shared/OTPLoginUI.tsx 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6412      +/-   ##
==========================================
- Coverage   54.73%   54.72%   -0.01%     
==========================================
  Files         874      874              
  Lines       54620    54621       +1     
  Branches     3722     3722              
==========================================
- Hits        29895    29894       -1     
- Misses      24630    24633       +3     
+ Partials       95       94       -1     
Flag Coverage Δ
packages 54.72% <0.00%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
...irdweb/src/react/web/wallets/shared/OTPLoginUI.tsx 6.56% <0.00%> (ø)

... and 3 files with indirect coverage changes

@joaquim-verges joaquim-verges merged commit 9f1a77f into main Mar 5, 2025
32 of 33 checks passed
@joaquim-verges joaquim-verges deleted the _SDK_fix_Allow_resending_OTP_on_failures branch March 5, 2025 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages SDK Involves changes to the thirdweb SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants