-
Notifications
You must be signed in to change notification settings - Fork 476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] fix: Allow resending OTP on failures #6412
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 9ab7061 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
size-limit report 📦
|
d451451
to
f1de7b5
Compare
f1de7b5
to
9ab7061
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6412 +/- ##
==========================================
- Coverage 54.73% 54.72% -0.01%
==========================================
Files 874 874
Lines 54620 54621 +1
Branches 3722 3722
==========================================
- Hits 29895 29894 -1
- Misses 24630 24633 +3
+ Partials 95 94 -1
|
PR-Codex overview
This PR focuses on enhancing the OTP resend functionality and refining transaction error handling in the
thirdweb
package. It also updates test cases to improve clarity and accuracy.Detailed summary
smart-wallet-integration-v07.test.ts
for unauthorized transactions.OTPLoginUI.tsx
to show resend button when not sending.drop1155.test.ts
.