Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with AbstractAlgebra ideal interface #1577

Merged
merged 1 commit into from
Aug 17, 2024

Conversation

paemurru
Copy link
Contributor

Hopefully resolves the failing checks in Nemocas/AbstractAlgebra.jl#1731

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.67%. Comparing base (a7d6515) to head (79faa43).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1577      +/-   ##
==========================================
- Coverage   75.68%   75.67%   -0.02%     
==========================================
  Files         357      357              
  Lines      113579   113583       +4     
==========================================
- Hits        85966    85955      -11     
- Misses      27613    27628      +15     
Files Coverage Δ
src/Misc/PIDIdeal.jl 68.42% <100.00%> (+2.38%) ⬆️

... and 32 files with indirect coverage changes

@thofma
Copy link
Owner

thofma commented Aug 17, 2024

Things like

function ideal(R::Field, x...)
  return _ideal_pid(R, x...)
end

can be removed once the AA changes are available, right?

@thofma thofma merged commit 339e84a into thofma:master Aug 17, 2024
17 checks passed
@paemurru
Copy link
Contributor Author

Yes, exactly, that's the idea.

@thofma
Copy link
Owner

thofma commented Aug 17, 2024

Great! I'll do a release later today or tomorrow, which should make the tests happy in Nemocas/AbstractAlgebra.jl#1731.

@paemurru paemurru deleted the ep/ideal_interface branch August 19, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants