Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Oscar #4170 - too low precision in factoring #1640

Merged
merged 2 commits into from
Oct 23, 2024
Merged

fix Oscar #4170 - too low precision in factoring #1640

merged 2 commits into from
Oct 23, 2024

Conversation

thofma
Copy link
Owner

@thofma thofma commented Oct 9, 2024

No description provided.

@thofma
Copy link
Owner Author

thofma commented Oct 9, 2024

#1639 without the other commit

@thofma thofma marked this pull request as ready for review October 9, 2024 10:07
@thofma
Copy link
Owner Author

thofma commented Oct 9, 2024

@fieker do you have the condensed example?

@thofma thofma mentioned this pull request Oct 9, 2024
@fieker
Copy link
Collaborator

fieker commented Oct 9, 2024 via email

@thofma
Copy link
Owner Author

thofma commented Oct 9, 2024

The following is hanging for me with this change:

Zx, x = FlintZZ["x"]
k, a = number_field(swinnerton_dyer(3, x))
kt, t = k["t"]
g = swinnerton_dyer(8, x)
length(factor(change_base_ring(k, g))) == 8 # van Hoeij

P.S.: It is an example from the tests test/NfAbs/Elem.jl, which are currently hanging.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.85%. Comparing base (137e629) to head (2407ea8).
Report is 15 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1640      +/-   ##
==========================================
+ Coverage   75.80%   75.85%   +0.04%     
==========================================
  Files         361      361              
  Lines      113700   113720      +20     
==========================================
+ Hits        86192    86263      +71     
+ Misses      27508    27457      -51     
Files with missing lines Coverage Δ
src/NumField/NfAbs/Poly.jl 44.41% <100.00%> (ø)
src/NumField/NfAbs/PolyFact.jl 86.22% <100.00%> (+8.62%) ⬆️

... and 41 files with indirect coverage changes

@thofma
Copy link
Owner Author

thofma commented Oct 9, 2024

The NfAbs/Elem.jl test finished, but they took 1700 seconds compared to 230 seconds without the changes here.

@fieker
Copy link
Collaborator

fieker commented Oct 22, 2024

I checked out the th/facccc and it terminates on my machine in 150sec - now twice

@fieker
Copy link
Collaborator

fieker commented Oct 22, 2024

OK, 13sec in the previous version. I see the problem

@thofma thofma merged commit 637902b into master Oct 23, 2024
18 checks passed
@thofma thofma deleted the th/facccc branch October 23, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants