Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use set!, zero!, etc. in YET more places #1650

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

fingolfin
Copy link
Contributor

Also switch to Nemo.denominator! and Nemo.numerator!,
and remove add_two! which now is equivalent to add!(x, 2).

Also switch to Nemo.denominator! and Nemo.numerator!,
and remove add_two! which now is equivalent to `add!(x, 2)`.
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 97.36842% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.90%. Comparing base (4ffee6e) to head (d26a6de).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/AlgAssAbsOrd/PIP/bley_johnston.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1650      +/-   ##
==========================================
+ Coverage   75.81%   75.90%   +0.09%     
==========================================
  Files         361      361              
  Lines      113702   113687      -15     
==========================================
+ Hits        86200    86293      +93     
+ Misses      27502    27394     -108     
Files with missing lines Coverage Δ
src/AlgAss/Elem.jl 88.54% <100.00%> (ø)
src/AlgAss/Map.jl 79.61% <100.00%> (ø)
src/Hecke.jl 51.61% <ø> (ø)
src/LinearAlgebra/LatEnum.jl 80.36% <100.00%> (ø)
src/Misc/CRT.jl 59.10% <100.00%> (+10.17%) ⬆️
src/Misc/Matrix.jl 76.87% <100.00%> (ø)
src/NumFieldOrd/NfOrd/Ideal/Arithmetic.jl 93.65% <100.00%> (ø)
src/NumFieldOrd/NfOrd/ResidueRing.jl 85.03% <100.00%> (-0.53%) ⬇️
src/QuadForm/Enumeration.jl 86.00% <100.00%> (+0.17%) ⬆️
src/AlgAssAbsOrd/PIP/bley_johnston.jl 66.16% <80.00%> (ø)

... and 27 files with indirect coverage changes

@thofma
Copy link
Owner

thofma commented Oct 17, 2024

I guess some of the downstream tests changed their name?

@lgoettgens
Copy link
Contributor

there just was another OscarDevTools.jl release that reverted this name change

@benlorenz
Copy link
Contributor

benlorenz commented Oct 17, 2024

there just was another OscarDevTools.jl release that reverted this name change

Yes, sorry about that, it was to fix the GLIBCXX errors for julia 1.6. But I realized too late that this changes all the names.
The change is not really necessary anyway since:

  • github reverted the change for ubuntu-latest (from 22.04 to 24.04)
  • I have made some new binaries which also avoids the error (at least for now)

Re-running the generatematrix step should create new jobs with ubuntu-latest as a name again.

@thofma
Copy link
Owner

thofma commented Oct 17, 2024

Thanks @benlorenz

@thofma thofma enabled auto-merge (squash) October 17, 2024 20:41
@thofma thofma merged commit 276ac56 into thofma:master Oct 17, 2024
17 checks passed
@fingolfin fingolfin deleted the mh/nemo-set-more branch October 17, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants