Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix logging path #61

Merged
merged 1 commit into from
Sep 24, 2020
Merged

fix logging path #61

merged 1 commit into from
Sep 24, 2020

Conversation

genofire
Copy link
Contributor

No description provided.

@thomas-maurice
Copy link
Owner

@DO1JLR what do you think, changing paths like that (like in #62) is likely to break existing installs isnt it ?

@genofire
Copy link
Contributor Author

I do not know what you mean with #62 ....

This PR fix the inconsistense between:

ROOT_PATH = {{ gitea_home }}/log

and
- "{{ gitea_home }}/logs"

I believe the ansible creating path has no effect to the gitea installation ... gitea creats /log like in the ini file descripted at his own.

@thomas-maurice
Copy link
Owner

oooooooh fuck

My bad, I did not review that thoroughly enough, indeed you are right @genofire, sorry about that ! This can indeed be merged.

Thank you for doing that :)

Copy link
Owner

@thomas-maurice thomas-maurice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@thomas-maurice thomas-maurice merged commit 883b6d9 into thomas-maurice:master Sep 24, 2020
@genofire genofire deleted the patch-1 branch September 24, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants